Re: [dev-servo] Consider using GitCop

2017-06-02 Thread Sean McArthur
> I'm not very fond of the length limit imposed by GitCop. The length is configurable. On Fri, Jun 2, 2017 at 8:50 AM Anthony Ramine wrote: > > > > Le 2 juin 2017 à 17:00, Boris Zbarsky a écrit : > > > > On 6/2/17 5:18 AM, Anthony Ramine wrote: > >> In the following screenshot, you can see one

Re: [dev-servo] Upgrading Hyper version in Servo

2016-10-29 Thread Sean McArthur
Ah, that pull request was merged into master. I can backport it to 0.9, and release a new version... Having added variants to an enum is usually a breaking change... On Sat, Oct 29, 2016, 7:53 AM Manish Goregaokar wrote: > ./mach update-cargo -p hyper > > should work > -Manish Goregaokar > > > O

Re: [dev-servo] How to shut down a WebSocket server

2016-09-12 Thread Sean McArthur
> > This may be a silly question, but why doesn't hyper come with > WebSockets support out of the box? It seems like "part of" HTTP to > some extent. > Sorry this is offtopic from the subject, but just wanted to address the question: You won't find websockets in hyper for the same reason you won'

Re: [dev-servo] Adding Windows CI

2015-05-10 Thread Sean McArthur
It can be a sanity check that a library builds on Windows. Mostly that all its dependencies don't suddenly lose support or stop compiling. That's the only reason I'm considering doing so for hyper. On Sun, May 10, 2015, 2:11 AM Simon Sapin wrote: > On 10/05/2015 06:01, Manish Goregaokar wrote:

Re: [dev-servo] Let's turn off deny(unused_imports) and deny(unused_variables)

2015-02-08 Thread Sean McArthur
I've found that setting those sorts of lints to be on only for tests to be best of both worlds. Such as #[cfg_attr(test, deny(warnings))]. On Sun, Feb 8, 2015, 10:53 PM Josh Matthews wrote: > These are frequent source of frustration for me, especially when > commenting out bits of code for when

Re: [dev-servo] Fwd: Re: Reviewing the SpiderMonkey upgrade for Servo

2014-10-17 Thread Sean McArthur
On Fri, Oct 17, 2014 at 1:31 PM, Manish Goregaokar wrote: > I'm pretty sure the must_root lint stops this from happening, except in a > couple of cases which are pretty convoluted and not likely to come up. > Those are the worst cases, cause they'll still happen, you can just never reproduce the