Re: [dev-servo] Test cases for (incremental) compile times (PSA: disable incremental compilation for now)

2017-10-04 Thread Nicholas Matsakis
On Tue, Oct 3, 2017 at 4:19 PM, Simon Sapin wrote: > On 03/10/2017 21:51, Nicholas Matsakis wrote: >> >> That said, the measurements I just did today still showed big wins >> (~3x), at least for the sample changes that I've been making (adding >> new methods, chan

Re: [dev-servo] PSA: disable incremental compilation for now

2017-10-03 Thread Nicholas Matsakis
That said, the measurements I just did today still showed big wins (~3x), at least for the sample changes that I've been making (adding new methods, changing method bodies in style). So it may be worth testing. Let me use this opportunity to ask a question: I'd love to get some help coming up wit

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Nicholas Matsakis
Something I learned the hard way is to avoid a sentence like this one: "Does not fix #123." Github will dutifully detect "fix #123" and close the corresponding issue. =) On Wed, Mar 1, 2017 at 10:21 AM, Alan Jeffrey wrote: > The other thing I learned the hard way is not to #N-mention any