Re: [dev-servo] Should commits landed in servo individually pass all tests?

2017-11-02 Thread Gregory Szorc
On Thu, Nov 2, 2017 at 5:00 PM, Manish Goregaokar wrote: > So I and emilio were discussing whether or not to squash > https://github.com/servo/servo/pull/18750 and it seemed like we have > different ideas of how "atomic" commits should be before landing. > > When we land pull requests in servo/se

Re: [dev-servo] RFC: Require Python 2.7.9+ (for TLS Server Name Indication)

2017-10-19 Thread Gregory Szorc
On Thu, Oct 19, 2017 at 4:38 PM, Simon Sapin wrote: > On 18/10/2017 22:37, Gregory Szorc wrote: > >> The latter merely requires an up-to-date trusted CA >> certificate roots bundle for x509 certificate verification (assuming the >> client does certificate validatio

Re: [dev-servo] RFC: Require Python 2.7.9+ (for TLS Server Name Indication)

2017-10-18 Thread Gregory Szorc
On Wed, Oct 18, 2017 at 10:01 PM, Simon Sapin wrote: > On 18/10/2017 21:09, Gregory Szorc wrote: > >> Having somewhat recently overhauled Mercurial’s TLS code, I can tell >> you that Python installs without the ssl module additions added in >> 2.7.9 are still quite commo

Re: [dev-servo] RFC: Require Python 2.7.9+ (for TLS Server Name Indication)

2017-10-18 Thread Gregory Szorc
> On Oct 18, 2017, at 20:31, Simon Sapin wrote: > > Servo downloads appropriate versions of Rust and Cargo using Python’s > urllib2. At some point, https://static.rust-lang.org started requiring TLS > SNI (I think when it moved to a CDN?) and we had issues with downloads > failing on CI or o

Re: [dev-servo] Consider using GitCop

2017-06-02 Thread Gregory Szorc
On Fri, Jun 2, 2017 at 8:00 AM, Boris Zbarsky wrote: > On 6/2/17 5:18 AM, Anthony Ramine wrote: > >> In the following screenshot, you can see one doesn't even know what that >> commit is supposed to do from its title, because it is way too long to be >> informative. >> > > OK, what is the propose

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-09 Thread Gregory Szorc
> On Feb 9, 2017, at 01:51, Anthony Ramine wrote: > > I'm not against the decision if we are willing to revert it in the future > (which is why I didn't reply immediately following your reply), but I have a > few things to say nonetheless. > >> Le 8 févr. 2017 à 19:42, Bobby Holley a écrit

[dev-servo] Intent to vendor Servo in mozilla-central

2017-01-03 Thread Gregory Szorc
Over in bug 1322769, we're planning to vendor the contents of the Servo Git repository into mozilla-central as part of Quantum efforts. The initial vendoring of the Servo repository is the first milestone of a larger project that aims to "unify" workflows and automation across the two projects, al

Re: [dev-servo] Proposal: remove mingw Servo builds in favor of msvc

2016-09-08 Thread Gregory Szorc
On Thu, Sep 8, 2016 at 10:32 AM, Lars Bergstrom wrote: > On Thu, Sep 8, 2016 at 11:01 AM, Gregory Szorc wrote: > > > > I would favor going the Clang route for supporting building with OSS on > > Windows. MinGW for better or worse is not just a toolchain: it's a min

Re: [dev-servo] Proposal: remove mingw Servo builds in favor of msvc

2016-09-08 Thread Gregory Szorc
On Thu, Sep 8, 2016 at 8:40 AM, Nathan Froyd wrote: > On Thu, Sep 8, 2016 at 11:11 AM, Gervase Markham wrote: > > On 08/09/16 16:08, Lars Bergstrom wrote: > >> That said, I know that there are a few benefits on the mingw side: > > > > (4) Build Servo on Windows using only free software? > >

Re: [dev-servo] The size of the tests/ directory

2016-08-25 Thread Gregory Szorc
> On Aug 24, 2016, at 09:12, Lars Bergstrom wrote: > > Currently, the GitHub Servo repository has 134,062 files... 131,477 of > which are in the tests/ directory. Of those, 102,871 are in the CSS WG > tests. I know it's not a perfect measure, but that's also 862megs of > the 1.132gb of disk space

[dev-servo] Moving away from merge commits

2016-04-27 Thread Gregory Szorc
Servo developers, I noticed that Servo and a number of other Servo related Git repos have tons of merge commits. This is the Git[Hub] way after all: create a merge commit for every pull request. The thing is, I'm not a huge fan of merge commits in version control, especially for large projects. I

Re: [dev-servo] Using Cargo in Gecko

2015-12-23 Thread Gregory Szorc
On Tue, Dec 22, 2015 at 1:46 PM, Yehuda Katz wrote: > I want to make sure that I understand the core constraints here: > >1. Gecko wants to be able to reliably do builds (especially urgent >ones) without relying on the uptime of third party services. >2. Gecko's build bots do not have

Re: [dev-servo] Using Cargo in Gecko

2015-12-22 Thread Gregory Szorc
On Tue, Dec 22, 2015 at 7:02 AM, Simon Sapin wrote: > On 22/12/15 03:55, gsz...@mozilla.com wrote: > >> The *only* way to prevent [race conditions] is for there to be a >> single source of truth. >> > > Yes, I think that’s an important point. > > > An alternative is to make mozilla-central the ca

Re: [dev-servo] Using Cargo in Gecko

2015-12-21 Thread Gregory Szorc
On Mon, Dec 21, 2015 at 2:29 PM, Bobby Holley wrote: > On Mon, Dec 21, 2015 at 2:21 PM, Yehuda Katz wrote: > >> On Mon, Dec 21, 2015 at 2:14 PM, Bobby Holley >> wrote: >> >> > I don't think this is going to fly in Gecko, unfortunately. >> > >> > Gecko is a monolithic repo, and everything needs