Re: [dev-servo] Re-enable non_snake_case warnings?

2020-01-09 Thread Cheng You Bai
No objection either! but, currently, there are some functions which will be communicated with mozjs bindings are named in camel case. Would it be good to keep them in camel case way? (ex. *HostResolveImportedModule* for *SetModuleResolveHook*) On Fri, Jan 10, 2020 at 5:59 AM Simon Sapin wrote: >

Re: [dev-servo] Re-enable non_snake_case warnings?

2020-01-09 Thread Simon Sapin
On 09/01/2020 22:33, Josh Matthews wrote: After coming across an instance of a non-snake case variable name that didn't trigger any compiler warnings, I discovered that we disabled that warning for the script crate 5 years ago (https://github.com/servo/servo/commit/dc86e8365495acc87b983a290bb7277

[dev-servo] Re-enable non_snake_case warnings?

2020-01-09 Thread Josh Matthews
After coming across an instance of a non-snake case variable name that didn't trigger any compiler warnings, I discovered that we disabled that warning for the script crate 5 years ago (https://github.com/servo/servo/commit/dc86e8365495acc87b983a290bb7277a37a5247f#diff-7efb30b262e93375ff2af348d5