Re: [dev-servo] println!("Hello from NCSU");

2019-04-22 Thread Josh Bowman-Matthews
This is why I provided a test command that only ran the tests in a particular subdirectory, and suggested "(with modifications)" to the commands listed in the readme. Cheers, Josh On 4/22/19 2:23 PM, Akhilesh Venkatasubramanian wrote: HI Josh, Thanks for the inputs, the code now compiles and

Re: [dev-servo] println!("Hello from NCSU");

2019-04-22 Thread Akhilesh Venkatasubramanian
HI Josh, Thanks for the inputs, the code now compiles and ./mach build -dev works. Now I am trying to run ./mach test-wpt --log-raw /tmp/servo.log to ge the logs formed and then run ./mach update-wpt /tmp/servo.log to update the results. But there are 25172 tests to be completed. Is there any

Re: [dev-servo] println!("Hello from NCSU");

2019-04-22 Thread Josh Bowman-Matthews
Based on the output of grepping `tests/wpt/web-platform-tests/webaudio` for `setValueCurve`, you will want to run `./mach test-wpt tests/wpt/web-platform-tests/webaudio/the-audio-api` to observe changes in test results caused by implementing this missing API. You can follow (with modifications)

Re: [dev-servo] println!("Hello from NCSU");

2019-04-22 Thread Josh Bowman-Matthews
`*values` is dereferencing the Vec value, which produces a slice (&[]). What you need to do instead is produce a new vector of dereferenced Finite values instead: `values.into_iter().map(|v| *v).collect()` cheers, Josh On 4/22/19 2:32 AM, Akhilesh Venkatasubramanian wrote: Hi Josh, I tried t