Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread Jack Moffitt
Let's allow until Friday afternoon for feedback to come in, but I don't think it makes sense to delay this decision. jack. On Wed, Feb 8, 2017 at 12:23 PM, Simon Sapin wrote: > On 08/02/17 19:42, Bobby Holley wrote: >> >> Won't they need to do this anyway? At least assuming we accept your >> pro

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread Simon Sapin
On 08/02/17 19:42, Bobby Holley wrote: Won't they need to do this anyway? At least assuming we accept your proposal below that: "Whenever a PR to rust-selectors (and other repositories where we think that’s appropriate) makes breaking changes, we don’t land it until there’s also a corresponding P

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread Bobby Holley
On Wed, Feb 8, 2017 at 2:28 AM, Anthony Ramine wrote: > Could you please push the code you wanted to test on your GH's fork, > so we can at least see what prompted this discussion? > I haven't split it out yet, because I'm still hoping that the outcome of this discussion is that I won't have to.

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread David Bruant
Le 08/02/2017 à 12:39, Simon Sapin a écrit : So here is a proposal to avoid this situation in the future: Whenever a PR to rust-selectors (and other repositories where we think that’s appropriate) makes breaking changes, we don’t land it until there’s also a corresponding PR to update Servo fo

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread Simon Sapin
It’s a trade-off. It’s true that historically we’ve been more eager than necessary to put every crate going to crates.io in its own repository. (See for example github.com/servo/webrender_traits, since then merged into webrender.) I understand that juggling multiple repositories makes things

Re: [dev-servo] Proposal: move the source code for rust-selectors into servo/servo

2017-02-08 Thread Anthony Ramine
Could you please push the code you wanted to test on your GH's fork, so we can at least see what prompted this discussion? Regards. > Le 7 févr. 2017 à 22:47, Bobby Holley a écrit : > > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://l