It's in tidy.
https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py#L287
On Thu, Jun 23, 2016 at 10:16 AM Manish Goregaokar
wrote:
> I think it is in tidy
>
> dev-servo@lists.mozilla.org wrote:
> > I thought we had CI checks for duplicate packages, but it seems that
> > is no
I think it is in tidy
dev-servo@lists.mozilla.org wrote:
> I thought we had CI checks for duplicate packages, but it seems that
> is not the case? Or at least I did not seem them in .etc/ci. I can't
> even find an issue for it now :(
>
> In any case, I think this can be automated by CI to catch th
I thought we had CI checks for duplicate packages, but it seems that
is not the case? Or at least I did not seem them in .etc/ci. I can't
even find an issue for it now :(
In any case, I think this can be automated by CI to catch the problem.
In general this is allowed by Cargo but we probably only
And what about the case of major version bumps? Presumably we want to crawl
the Cargo.toml files in that case? And again, will it be obvious that needs
to happen from the Cargo.lock diff?
On Thu, Jun 23, 2016 at 9:32 AM, Manish Goregaokar
wrote:
> We rarely use ranges, just a minimum version, an
We rarely use ranges, just a minimum version, and aside from major version
differences cargo just picks the max.
dev-servo@lists.mozilla.org wrote:
> Is there a risk that non-overlapping version ranges in dependent Cargo.toml
> files will cause multiple versions of the package to be imported? Or
Is there a risk that non-overlapping version ranges in dependent Cargo.toml
files will cause multiple versions of the package to be imported? Or would
that be obvious when looking at the Cargo.lock diff?
On Thu, Jun 23, 2016 at 7:17 AM, Josh Matthews
wrote:
> https://github.com/servo/servo/pull/
https://github.com/servo/servo/pull/11824 relies on upgrading hyper to a
more recent version. As far as I recall, for servo/servo we have only
ever asked people to upgrade the package version via `./mach
cargo-update`; we haven't required (or even asked for) modifying all of
our many TOML files
7 matches
Mail list logo
