Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Simon Sapin
On 31/10/15 03:00, Pranesha Shashwath Kumar Kattepura Jayabheema Rao wrote: Hi, We are getting an error "This function takes 4 parameters but 3 were supplied" for all the instances of the function get_specified!. Adding to what Josh said: get_specified! is not a function, it’s a macro. (Th

[dev-servo] Error in ./mach test-tidy

2015-10-31 Thread JIGAR SHARDA
Hi All, I am trying to add a new interface and while running the ./mach test-tidy, I am getting an error saying that no specification link found for the interface at line 0 of the newly added file. My ./mach build --dev is running fine. So can you please point what am I missing here? Thanks in ad

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Josh Matthews
In answer to your question, the change that is causing all of these errors is https://github.com/GauriGNaik/servo/commit/c8b79b964d9f5225196a307102442abf3352c43b#diff-1816aa410246f8915a124610d4e5bc3cR5620 .. You need to modify http://mxr.mozilla.org/servo/source/components/style/properties.ma

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Pranesha Shashwath Kumar Kattepura Jayabheema Rao
Thanks for the info. The small change we made to struct ParserContext in parser.rs seems to have lots of dependencies. This seems to be a scenario of metaprogramming where a new function is being created at run-time. Could you please help us understand if changing this function to accept 4 values w