On 2015-09-13 8:19 PM, Anthony Ramine wrote:
I see. I've also noticed that pushing new code doesn't remove S-needs-rebase if
the code can now merge. Is that intended too?
Le 14 sept. 2015 à 02:12, Josh Matthews a écrit :
No; S-needs-rebase is applied automatically to PRs when homu posts a Me
I see. I've also noticed that pushing new code doesn't remove S-needs-rebase if
the code can now merge. Is that intended too?
Le 14 sept. 2015 à 02:12, Josh Matthews a écrit :
> No; S-needs-rebase is applied automatically to PRs when homu posts a Merge
> Conflict comment. It intentionally does
On 2015-09-13 7:57 PM, Anthony Ramine wrote:
S-needs-rebase and S-awaiting-review should be mutually exclusive though, right?
Le 14 sept. 2015 à 01:49, Josh Matthews a écrit :
I will point out that any PR with S-awaiting-review should not be closed; that
means that the failure is on our end
S-needs-rebase and S-awaiting-review should be mutually exclusive though, right?
Le 14 sept. 2015 à 01:49, Josh Matthews a écrit :
> I will point out that any PR with S-awaiting-review should not be closed;
> that means that the failure is on our end since new code has been pushed
> since the
I will point out that any PR with S-awaiting-review should not be
closed; that means that the failure is on our end since new code has
been pushed since the last time someone reviewed it.
On 2015-09-13 9:00 AM, Anthony Ramine wrote:
Hello,
There are currently more than 60 PRs opened, and the
Sounds great.
I believe that proactively closing our own PRs with that label would motivate
us to revive the important ones, like pcwalton:omtc.
Le 13 sept. 2015 à 17:29, Josh Matthews a écrit :
> The label S-needs-new-owner was intended for PRs that appear to be abandoned
> and are still des
The label S-needs-new-owner was intended for PRs that appear to be
abandoned and are still desirable, so we could link to
https://github.com/servo/servo/pulls?q=is%3Apr+is%3Aclosed+label%3AS-needs-new-owner
for a list of closed PRs with that label applied, I guess.
Cheers,
Josh
On 2015-09-13
Hello,
There are currently more than 60 PRs opened, and the oldest one's ID is 3,000
lower than the newest. This is starting to get out of hand. I suggest we should
be Always Be Closing stale pull requests instead of letting them linger. We
could have a wiki page or something of interesting pat
8 matches
Mail list logo
