Re: [dev-servo] Recent Improvements to Functions like getClientBoundingRect

2014-08-29 Thread Cameron Zwarich
I filed both of the issues discussed on this thread: https://github.com/servo/servo/issues/3187 https://github.com/servo/servo/issues/3188 Cameron On Aug 28, 2014, at 7:20 PM, Patrick Walton wrote: > I believe the answer today is "nothing"--i.e. it's a Servo bug. Clark's work > doubles as a n

Re: [dev-servo] Recent Improvements to Functions like getClientBoundingRect

2014-08-29 Thread Patrick Walton
On 8/29/14 5:27 AM, Lars Bergstrom wrote: In general, I'd be a little wary of adding global locks into Servo unless it's really necessary (i.e., if it turns out we can't architect away the race condition Cameron brought up in any other way). Since we haven't found a good way to do any concurrent

Re: [dev-servo] Recent Improvements to Functions like getClientBoundingRect

2014-08-29 Thread Josh Matthews
On 2014-08-29 9:52 AM, Josh Matthews wrote: On 2014-08-29 8:27 AM, Lars Bergstrom wrote: At that point, I'd expect script to layout calls via message passing to be much cheaper than a mutex acquisition, but would be very interested to see numbers comparing them! To be clear, we're spawning a g

Re: [dev-servo] Recent Improvements to Functions like getClientBoundingRect

2014-08-29 Thread Josh Matthews
On 2014-08-29 8:27 AM, Lars Bergstrom wrote: On Aug 28, 2014, at 9:26 PM, Cameron Zwarich wrote: As a side point, why is there a 7 us overhead here for message-passing between green threads? Is it really that bad? Are script and layout currently green tasks, or did something land causing this

Re: [dev-servo] Recent Improvements to Functions like getClientBoundingRect

2014-08-29 Thread Lars Bergstrom
On Aug 28, 2014, at 9:26 PM, Cameron Zwarich wrote: > On Aug 28, 2014, at 5:45 PM, Clark Gaebel wrote: > >> Running this on Firefox takes 500 ns/iteration. Chrome takes 700 >> ns/iteration. >> >> Servo before [1] lands took 8100 ns! That's paying a lot (some would say too >> much) for a para