ExposureGuidelines updated (was Re: Intent to implement: CSS text-justify property)

2017-02-08 Thread Kan-Ru Chen
On Thu, Feb 9, 2017, at 12:28 AM, Boris Zbarsky wrote: > On 2/8/17 5:08 AM, Jeremy Chen wrote: > > Link to standard: https://drafts.csswg.org/css-text-3/#text-justify-property > > How stable is this spec? > > Note that even if it's unstable that shouldn't stop us implementing; > that mostly affe

New sync IPC messages will require IPC peers' review

2017-02-19 Thread Kan-Ru Chen
Hi, In order to reduce the performance issues caused by sync IPC messages, we are tracking and removing sync IPCs from the content process or the UI thread[1]. With bug 1336919 landed[[2] all additions of new sync messages must be recorded in ipc/ipdl/sync-messages.ini and reviewed by an IPC peer.

Re: Tier 3 win64 ASan builds on try

2017-04-07 Thread Kan-Ru Chen
Hooray! Thanks for making tests working on Windows! Kanru On Thu, Apr 6, 2017, at 10:14 PM, Jeff Muizelaar wrote: > Glorious. Thanks to everyone who made this happen. > > -Jeff > > On Thu, Apr 6, 2017 at 10:11 PM, Ting-Yu Chou wrote: > > Just a heads up that now we have win64 ASan builds on t

IPDL now supports async returns with MozPromise

2017-04-19 Thread Kan-Ru Chen
Hello! With bug 1313200 landed, async IPC messages can now return data via MozPromises. The IPDL syntax: protocol PFoo { child: async Bar() returns (bool param); }; will generate IPC code that allow the send method like this: SendBar()->Then(AbstractThread::GetCurrent()

Re: Is Big5 form submission fast enough?

2017-05-11 Thread Kan-Ru Chen
On Thu, May 11, 2017, at 01:43 PM, Henri Sivonen wrote: > In Firefox 43, I rewrote our Big5 support and, among other things, I > optimized the *encoder* for footprint rather than speed on the theory > that users won't notice anyway since the encoder run is followed by a > dominating wait for the ne

Re: Avoiding jank in async functions/promises?

2017-05-17 Thread Kan-Ru Chen
On Thu, May 18, 2017, at 10:10 AM, L. David Baron wrote: > On Thursday 2017-05-18 11:22 +1000, Mark Hammond wrote: > > I'm wondering if there are any ideas about how to solve this optimally? > > Naively, it seems that the (broadest sense of the term) "platform" might be > > able to help here using

Re: how exactly are the P*.h files generated ?

2017-07-23 Thread Kan-Ru Chen
Hi! On Sun, Jul 23, 2017, at 03:42 PM, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > I've got some trouble w/ regenarating > ./obj-thunderbird/ipc/ipdl/_ipdlheaders/mozilla/dom/PContentParent.h > > > I had to change ./mozilla/dom/ipc/ContentParent.h to ifdef-out some > methods (trying

Re: sccache as ccache

2017-07-26 Thread Kan-Ru Chen
On Wed, Jul 26, 2017, at 09:05 PM, Ted Mielczarek wrote: > Yesterday I published sccache 0.2 to crates.io, so you can now `cargo > install sccache` and get the latest version (it'll install to > ~/.cargo/bin). If you build Firefox on Linux or OS X you can (and > should) use sccache in place of ccac

Re: Coding style question: Meaningless argument names in declarations

2017-09-08 Thread Kan-Ru Chen
On Thu, Sep 7, 2017, at 11:16 PM, Emilio Cobos Álvarez wrote: > This is very context dependent, I'd never omit a name in a function that > takes (Element& aParent, Element& aChild), but it seems reasonable to > omit it in the case where there's no better name, like (InsertionKind > aInsertionKind)

PSA: mozilla/unused.h renamed to mozilla/Unused.h

2016-08-26 Thread Kan-Ru Chen
Hello, In Bug 1297276 I landed a patch to rename mozilla/unused.h to mozilla/Unused.h to make it more consistent with our other MFBT headers. Normally rename a header shouldn't cause too much trouble, however this rename is only changing the case so you might experience some problems on case insen

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

2016-08-27 Thread Kan-Ru Chen
On Sat, Aug 27, 2016, at 11:35 AM, Gregory Szorc wrote: > On Fri, Aug 26, 2016 at 8:27 PM, Steve Fink wrote: > > > On 08/26/2016 08:16 PM, Gregory Szorc wrote: > > > >> > >> On Aug 26, 2016, at 19:54, Kan-Ru Chen wrote: > >>> > >>>

Re: Intent to restrict to secure contexts: navigator.geolocation

2016-10-24 Thread Kan-Ru Chen
On Sat, Oct 22, 2016, at 09:38 PM, Richard Barnes wrote: > On Fri, Oct 21, 2016 at 5:56 PM, Ehsan Akhgari > wrote: > > Since the proposal in the bug is adding [SecureContext] to > > Navigator.geolocation, have we also collected telemetry around which > > properties and methods are accessed? Since

PSA: The return type of IPDL Recv* methods changed from bool to mozilla::ipc::IPCResult

2016-11-16 Thread Kan-Ru Chen
Hello, In bug 1314254 the return type of IPDL Recv* methods was changed from bool to mozilla::ipc::IPCResult in order to make crash reports to have better stack information. There are now three choices to return from a Recv* method: 1. return IPC_OK(); where previously we return true 2. return IP

Re: Expanding regular regression triage to include crashes?

2016-12-19 Thread Kan-Ru Chen
On Thu, Dec 15, 2016, at 11:17 AM, Ryan VanderMeulen wrote: > I like the idea in principle, but in practice, two meetings a week is > already not enough to get through regression bugs. Are we going to add > more meetings to accommodate this? And I'll note that already, > attendance of the regula

Re: Intent to Implement: User Timing API

2014-12-11 Thread Kan-Ru Chen
Yes! The marks could be used by SPS or Tasktracer! Kyle Machulis writes: > Small correction, the preference should be dom.enable_user_timing, not > dom.enable_performance > > - Original Message - > >> From: "Jonas Sicking" >> To: "Kyle Machulis" >> Cc: "dev-platform" , "dev-webapi" >