Re: Hiding 'new' statements - Good or Evil?

2017-11-23 Thread bowen
I'm not sure what the benefits are (the MakeUnique comments only really seem to give aesthetic ones), but they do make it a bit harder when searching through code to see where things are constructed. I suppose if we always stick to using Make* then (with regex) it wouldn't add too much burden f

Re: Hiding 'new' statements - Good or Evil?

2017-11-23 Thread Jeff Gilbert
I agree that MakeNotNull doesn't sound like it allocates. Reads to me as Make[Into]NotNull. Context will *usually* make this clear, but why not NewNotNull? (Honestly I don't like MakeUnique to begin with) NotNull::New(args...) is another option. "My first goal was to avoid the unnecessary nullptr

Re: Hiding 'new' statements - Good or Evil?

2017-11-23 Thread Jonathan Kew
On 23/11/2017 12:05, Jeff Gilbert wrote: I agree that MakeNotNull doesn't sound like it allocates. Reads to me as Make[Into]NotNull. Context will *usually* make this clear, but why not NewNotNull? (Honestly I don't like MakeUnique to begin with) As far as naming is concerned, ISTM that "Create.

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-11-23 Thread Alexey Zvyagin
And fresh reports too from today: Linux Mitn (may be without addons too): https://crash-stats.mozilla. com/report/index/a512c1fa-f6c1-4c89-8649-489c71171121 Ubuntu - during i am writting this email (!): https://crash-stats.mozilla.com/report/index/b25bb2ba-45dd-4124-bc9c-ad8ef1171121 Ubuntu - othe

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-11-23 Thread Alexey Zvyagin
Hello All, Today i had set up new computer (Linux Mint) Before finish i set up a syncing. But before i catch permanent CPU eating in new Firefox i saw that there no addons. Only bookmarked were synced. After restarting and posting crash report i checked Firefox - there were not addons yet. So i th

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-11-23 Thread Alexey Zvyagin
Linux Mint - it's new computer. I started there syncing only today. I have Firefox in work - there are Windows 7 and same problem... (i sent crash reports from Windows) I don't think that there in all computers are corrupted DB... I turned off now all bookmark related add-ons: "Go parent folder",

Re: Hiding 'new' statements - Good or Evil?

2017-11-23 Thread Botond Ballo
I think it makes sense to hide a 'new' call in a Make* function when you're writing an abstraction that handles allocation *and* deallocation. So MakeUnique makes sense, because UniquePtr takes ownership of the allocated object, and will deallocate it in the destructor. MakeRefPtr would make sense

Re: Hiding 'new' statements - Good or Evil?

2017-11-23 Thread smaug
On 11/23/2017 11:54 PM, Botond Ballo wrote: I think it makes sense to hide a 'new' call in a Make* function when you're writing an abstraction that handles allocation *and* deallocation. So MakeUnique makes sense, because UniquePtr takes ownership of the allocated object, and will deallocate it