Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Gerald Squelart
On Friday, September 18, 2015 at 3:55:27 AM UTC+10, Andrew McCreight wrote: > On Thu, Sep 17, 2015 at 7:42 AM, Andrew McCreight > wrote: > > > > On Thu, Sep 17, 2015 at 5:31 AM, Gerald Squelart > > wrote: > > > >> Good stuff! > >> > >> I hope you'll consider tracking AddRef's and Release's as well.

Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Nick Fitzgerald
Note that for JS objects (and JS strings very soon), you can track allocation stacks with the Debugger API: https://developer.mozilla.org/en-US/docs/Tools/Debugger-API/Debugger.Memory On Thu, Sep 17, 2015 at 10:55 AM, Andrew McCreight wrote: > On Thu, Sep 17, 2015 at 7:42 AM, Andrew McCreight

Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Andrew McCreight
On Thu, Sep 17, 2015 at 7:42 AM, Andrew McCreight wrote: > > > On Thu, Sep 17, 2015 at 5:31 AM, Gerald Squelart > wrote: > >> Good stuff! >> >> I hope you'll consider tracking AddRef's and Release's as well. >> >> I recently experimented with that for a troubled RefCounted class [1], >> and it w

Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Andrew McCreight
On Thu, Sep 17, 2015 at 5:31 AM, Gerald Squelart wrote: > Good stuff! > > I hope you'll consider tracking AddRef's and Release's as well. > > I recently experimented with that for a troubled RefCounted class [1], and > it was very useful to find which AddRef didn't have its corresponding > Releas

Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Gerald Squelart
Good stuff! I hope you'll consider tracking AddRef's and Release's as well. I recently experimented with that for a troubled RefCounted class [1], and it was very useful to find which AddRef didn't have its corresponding Release. Cheers, Gerald [1] https://hg.mozilla.org/try/rev/8dffaf0d2acf _

Re: easily getting allocation stacks for leaking objects

2015-09-16 Thread David Rajchenbach-Teller
That sounds great! Thanks a lot, David On 15/09/15 22:32, Nathan Froyd wrote: > Hi all, > > For some intermittent leaks, it's not at all clear where the leaked objects > are coming from, especially for objects that are widely used across the > codebase. Bug 1196430 added the ability for our le

Re: easily getting allocation stacks for leaking objects

2015-09-15 Thread Bobby Holley
This looks super useful - thanks Nathan! Tooling like this is critical to helping us get to the bottom of intermittent nastiness. On Tue, Sep 15, 2015 at 1:32 PM, Nathan Froyd wrote: > Hi all, > > For some intermittent leaks, it's not at all clear where the leaked objects > are coming from, espe

easily getting allocation stacks for leaking objects

2015-09-15 Thread Nathan Froyd
Hi all, For some intermittent leaks, it's not at all clear where the leaked objects are coming from, especially for objects that are widely used across the codebase. Bug 1196430 added the ability for our leak checking mechanism to track allocation stacks of objects and to print said stacks for le