Re: WebIDL consts now generate C++ definitions

2017-10-27 Thread Boris Zbarsky
On 10/27/17 12:33 PM, Steve Fink wrote: Within Spidermonkey, our rule is to never #include windows.h directly, but always via jswin.h Ah, I thought I'd seen this sort of thing somewhere; I had recalled a header that you could include to under "all the bad windows.h stuff"... This approach do

Re: WebIDL consts now generate C++ definitions

2017-10-27 Thread Steve Fink
On 10/26/17 8:22 PM, Kyle Machulis wrote: This addition also creates the new [NeedsWindowsUndef] extended attribute, as some WebIDL constant names conflict with windows.h macros, and undef'ing them in the binding generation is easier than tracking down include order issues. Gecko seems to handl

WebIDL consts now generate C++ definitions

2017-10-26 Thread Kyle Machulis
As of Bug 792059 landing, If you're adding new WebIDL interfaces to gecko, we will now generate constant definitions in the binding namespace of the C++ binding headers. For example, if you have a WebIDL interface that looks like --- interface TestExampleInterface { ... [NeedsWindowsUndef] c