Re: Using clang-cl to ship Windows builds

2018-08-21 Thread Stuart Philp
That is fantastic, lots of nice wins! On Tue, Aug 21, 2018 at 6:02 PM, David Major wrote: > A quick update about performance: ThinLTO and PGO were enabled for our > clang-cl builds over the last few weeks. These optimizations have > cancelled the previous regressions and brought clang well ahead

Re: Using clang-cl to ship Windows builds

2018-08-21 Thread David Major
A quick update about performance: ThinLTO and PGO were enabled for our clang-cl builds over the last few weeks. These optimizations have cancelled the previous regressions and brought clang well ahead of MSVC: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=2

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Anthony Jones
On Friday, 13 July 2018 11:26:07 UTC+12, Jörg Knobloch wrote: > On 10/07/2018 22:29, David Major wrote: > > Bug 1443590 is switching our official Windows builds to use clang-cl > > as the compiler. > > > > Please keep an eye out for regressions and file a blocking bug for > > anything that might b

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Jörg Knobloch
On 10/07/2018 22:29, David Major wrote: Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for anything that might be fallout from this change. I'm especially interested in hearing about the quality

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Mike Hommey
On Wed, Jul 11, 2018 at 11:34:52PM -0700, Anthony Jones wrote: > On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote: > > I hope that both Firefox and Chrome continue to keep the build and > > tests running on MSVC. It would suck if for example we can't build > > Firefox with MSVC

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread Anthony Jones
On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote: > I hope that both Firefox and Chrome continue to keep the build and tests > running on MSVC. It would suck if for example we can't build Firefox with > MSVC. I can't comment on Chrome. > Will the Firefox team publish builds

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread halivingston
On Wednesday, July 11, 2018 at 3:01:04 PM UTC-7, Mike Hommey wrote: > On Wed, Jul 11, 2018 at 09:48:23AM -0700, Thomas Daede wrote: > > On 07/10/2018 01:29 PM, David Major wrote: > > > Bug 1443590 is switching our official Windows builds to use clang-cl > > > as the compiler. > > > > Another great

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread Mike Hommey
On Wed, Jul 11, 2018 at 09:48:23AM -0700, Thomas Daede wrote: > On 07/10/2018 01:29 PM, David Major wrote: > > Bug 1443590 is switching our official Windows builds to use clang-cl > > as the compiler. > > Another great effect of this change is that it finally fixes the issue > of constantly runnin

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread Thomas Daede
On 07/10/2018 01:29 PM, David Major wrote: > Bug 1443590 is switching our official Windows builds to use clang-cl > as the compiler. Another great effect of this change is that it finally fixes the issue of constantly running out of virtual address space when linking Win32 builds: https://bugzilla

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread Sylvestre Ledru
Le 11/07/2018 à 14:01, pedro.lar...@gmail.com a écrit : > Is there a link to the required changes? I'm curious. One of the meta bug is: https://bugzilla.mozilla.org/show_bug.cgi?id=752004 Look at the list of "Depends on" to see what have been required! (not mentioning other related work like th

Re: Using clang-cl to ship Windows builds

2018-07-11 Thread pedro . larroy
Is there a link to the required changes? I'm curious. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread Bobby Holley
+1. This is really fantastic news, and frankly happened way faster than I would have thought possible. Thanks to everyone involved! On Tue, Jul 10, 2018 at 1:51 PM Gregory Szorc wrote: > On Tue, Jul 10, 2018 at 1:29 PM, David Major wrote: > >> Bug 1443590 is switching our official Windows build

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread David Major
At the moment, performance is a mixed bag. Some tests are up and some are down. In particular I believe Speedometer is down a few percent. Note however that clang-cl is punching above its weight. These builds currently have neither LTO nor PGO, while our MSVC builds use both of those. Any regressi

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread Gregory Szorc
On Tue, Jul 10, 2018 at 1:29 PM, David Major wrote: > Bug 1443590 is switching our official Windows builds to use clang-cl > as the compiler. > > Please keep an eye out for regressions and file a blocking bug for > anything that might be fallout from this change. I'm especially > interested in he

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread Chris Peterson
How does the performance of clang-cl builds compare to MSVC builds on benchmarks like Speedometer? On 2018-07-10 1:29 PM, David Major wrote: Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for

Using clang-cl to ship Windows builds

2018-07-10 Thread David Major
Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for anything that might be fallout from this change. I'm especially interested in hearing about the quality of the debugging experience. It's possib