Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-29 Thread Reuben Morais
On Nov 29, 2012, at 10:10 AM, Mounir Lamouri wrote: > If you really want to get rid of MOZ_MAKE_FLAGS, maybe you could add a > new variable to just set the -j value with a default to N if most people > thing this is the best value. +1. I often switch between -j4 and -j2 because the former makes m

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-29 Thread Mounir Lamouri
On 27/11/12 22:35, Gregory Szorc wrote: > I feel the build system should be as fast as possible by default - no > user action necessary. If you find that -j == # cores isn't providing > the fastest builds possible, please present your data and we'll change > the default value. I recently changed m

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-28 Thread Justin Dolske
On 11/28/12 9:59 AM, Zack Weinberg wrote: A gnumake flag that obsessive mozconfig tweakers may want to test is --load-average (-l). I played with this a bit in the past. My experience was that the load average reacts much too slowly to new processes, so Make would fire off a huge batch of com

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-28 Thread Zack Weinberg
On 2012-11-27 6:21 PM, Gregory Szorc wrote: On 11/27/12 2:55 PM, Chris Peterson wrote: On 11/27/12 2:35 PM, Gregory Szorc wrote: I feel the build system should be as fast as possible by default - no user action necessary. If you find that -j == # cores isn't providing the fastest builds possibl

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-28 Thread Neil
Gregory Szorc wrote: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7f5e2a9addff http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=7f5e2a9addff http://hg.mozilla.org/integration/mozilla-inbound/rev/ba730945bc6d https://bugzilla.mozilla.org/show_bug.cgi?id=815219 -- W

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-27 Thread Gregory Szorc
On 11/27/12 5:02 PM, Nicholas Nethercote wrote: On Tue, Nov 27, 2012 at 2:35 PM, Gregory Szorc wrote: If you have |-s|, if you build with |./mach build|, it uses silent mode by default, so again, you don't need MOZ_MAKE_FLAGS. What about --no-print-directory? I specify that too... mach als

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-27 Thread Nicholas Nethercote
On Tue, Nov 27, 2012 at 2:35 PM, Gregory Szorc wrote: > If you have |-s|, if you build with |./mach build|, it uses silent mode by > default, so again, you don't need MOZ_MAKE_FLAGS. What about --no-print-directory? I specify that too... Nick ___ dev-

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-27 Thread Gregory Szorc
On 11/27/12 2:55 PM, Chris Peterson wrote: On 11/27/12 2:35 PM, Gregory Szorc wrote: I feel the build system should be as fast as possible by default - no user action necessary. If you find that -j == # cores isn't providing the fastest builds possible, please present your data and we'll change

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-27 Thread Chris Peterson
On 11/27/12 2:35 PM, Gregory Szorc wrote: I feel the build system should be as fast as possible by default - no user action necessary. If you find that -j == # cores isn't providing the fastest builds possible, please present your data and we'll change the default value. A gnumake flag that obs

Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-27 Thread Gregory Szorc
Just landed in inbound [1] is a build system change that automatically defines make's |-j| argument (the parallel process count) to be the number of cores in your machine. Pending a backout, this means that you no longer need to do anything to leverage all the cores in your machine when buildin