Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-23 Thread Tom Tromey
Axel> The other "easy" way to reduce impact here is to reduce the use of Axel> nsTextFormatter, or create a replacement that doesn't crash. L20n Axel> would be one, or maybe there's C++ template stuff that can "taint" Axel> values with their original types. Tom> I don't think there is a compile-ti

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-22 Thread Tom Tromey
Axel> The other "easy" way to reduce impact here is to reduce the use of Axel> nsTextFormatter, or create a replacement that doesn't crash. L20n Axel> would be one, or maybe there's C++ template stuff that can "taint" Axel> values with their original types. Tom> I don't think there is a compile-ti

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-20 Thread axel
On Friday, February 20, 2015 at 6:34:07 PM UTC+1, Tom Tromey wrote: > > "Axel" == axel-4eJtQOnFJqFBDgjK7y7TUQ > > writes: > > Axel> We can only do this in the compiler if we actually compiled each > Axel> localized version by itself. > > Yes, I see what you mean. > > Axel> The other "

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-20 Thread Tom Tromey
> "Axel" == axel-4eJtQOnFJqFBDgjK7y7TUQ > writes: Axel> We can only do this in the compiler if we actually compiled each Axel> localized version by itself. Yes, I see what you mean. Axel> The other "easy" way to reduce impact here is to reduce the use of Axel> nsTextFormatter, or cr

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-20 Thread axel
On Friday, February 20, 2015 at 12:57:44 PM UTC+1, Ted Mielczarek wrote: > On Thu, Feb 19, 2015, at 06:32 AM, a...@mozilla.com wrote: > > On Tuesday, February 17, 2015 at 6:33:42 PM UTC+1, Ted Mielczarek wrote: > > > On Tue, Feb 17, 2015, at 10:27 AM, Axel Hecht wrote: > > > > Hi, > > > > > > > >

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-20 Thread Ted Mielczarek
On Thu, Feb 19, 2015, at 06:32 AM, a...@mozilla.com wrote: > On Tuesday, February 17, 2015 at 6:33:42 PM UTC+1, Ted Mielczarek wrote: > > On Tue, Feb 17, 2015, at 10:27 AM, Axel Hecht wrote: > > > Hi, > > > > > > I'd like to write tests to validate my assumptions around what's an error > > > and

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-19 Thread axel
On Thursday, February 19, 2015 at 11:27:11 PM UTC+1, Tom Tromey wrote: > > "Axel" writes: > > Axel> I'm talking actual crashes, and I don't know how we would fix the > Axel> text formatter. I'm glancing at > Axel> > http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsTextFormatter.cpp#

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-19 Thread Tom Tromey
> "Axel" == axel-4eJtQOnFJqFBDgjK7y7TUQ > writes: Axel> I'm talking actual crashes, and I don't know how we would fix the Axel> text formatter. I'm glancing at Axel> http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsTextFormatter.cpp#778, Axel> and I had no idea how to fix

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-19 Thread axel
On Tuesday, February 17, 2015 at 6:33:42 PM UTC+1, Ted Mielczarek wrote: > On Tue, Feb 17, 2015, at 10:27 AM, Axel Hecht wrote: > > Hi, > > > > I'd like to write tests to validate my assumptions around what's an error > > and what's a warning for localized values going into > > nsTextFormatter::sm

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-17 Thread Ted Mielczarek
On Tue, Feb 17, 2015, at 10:27 AM, Axel Hecht wrote: > Hi, > > I'd like to write tests to validate my assumptions around what's an error > and what's a warning for localized values going into > nsTextFormatter::smprintf. > > Basically, the tests would start with a reference string, and then a m

Testing for expected crashes in both C++ and js, for printf checking

2015-02-17 Thread Axel Hecht
Hi, I'd like to write tests to validate my assumptions around what's an error and what's a warning for localized values going into nsTextFormatter::smprintf. Basically, the tests would start with a reference string, and then a more or less random modification of that string, and a check if the