Re: Test failures in mochitest-browser caused by doing work inside DOM event handlers

2014-06-26 Thread Chris Mills
On 25 Jun 2014, at 15:18, Ed Morley wrote: > On 25/06/2014 15:16:04, Chris Mills wrote: >> It looks like a good place to put this information would be as a subsection >> of >> https://developer.mozilla.org/en/docs/Mochitest#Writing_tests >> >> Can you add in a brief section covering this point

Re: Test failures in mochitest-browser caused by doing work inside DOM event handlers

2014-06-25 Thread Ed Morley
On 25/06/2014 15:16:04, Chris Mills wrote: It looks like a good place to put this information would be as a subsection of https://developer.mozilla.org/en/docs/Mochitest#Writing_tests Can you add in a brief section covering this point, along with a brief code snippet illustrating a good and a b

Re: Test failures in mochitest-browser caused by doing work inside DOM event handlers

2014-06-25 Thread Chris Mills
On 8 May 2014, at 22:02, Irving Reid wrote: > I've recently fought my way through a bunch of intermittent test > failures in the Add-on Manager mochitest-browser suite, and there's a > common anti-pattern where tests receive a Window callback, usually > "unload", and proceed to do significant wo

Test failures in mochitest-browser caused by doing work inside DOM event handlers

2014-05-08 Thread Irving Reid
I've recently fought my way through a bunch of intermittent test failures in the Add-on Manager mochitest-browser suite, and there's a common anti-pattern where tests receive a Window callback, usually "unload", and proceed to do significant work inside that event handler (e.g. opening/closing/focu