Re: Some more PLDHashTable API tweaks

2015-04-30 Thread Nicholas Nethercote
An update on some pldhash changes that were backed out and then gradually relanded... On Wed, Feb 4, 2015 at 7:45 PM, Nicholas Nethercote wrote: > Hi, > > I just landed the patches in > https://bugzilla.mozilla.org/show_bug.cgi?id=1050035. They > affect PLDHashTable's API in the following ways. >

Re: Some more PLDHashTable API tweaks

2015-02-10 Thread Nicholas Nethercote
I had to back these changes out due to some infrequent and intermittent crashes and assertion failures, alas. Nick On Wed, Feb 4, 2015 at 7:45 PM, Nicholas Nethercote wrote: > Hi, > > I just landed the patches in > https://bugzilla.mozilla.org/show_bug.cgi?id=1050035. They > affect PLDHashTable'

Re: Some more PLDHashTable API tweaks

2015-02-06 Thread Nicholas Nethercote
On Fri, Feb 6, 2015 at 6:59 PM, Philip Chee wrote: >> >> - PLD_NewDHashTable() and PLD_HashTableDestroy() have been removed. You >> should >> now just use |new|+PL_DHashTableInit() and PLD_HashTableDestroy()+|delete|, > > ITYM PL_DHashTableFinish()+|delete| I do. Thank you for the correction.

Re: Some more PLDHashTable API tweaks

2015-02-06 Thread Philip Chee
On 05/02/2015 11:45, Nicholas Nethercote wrote: > Hi, > > I just landed the patches in > https://bugzilla.mozilla.org/show_bug.cgi?id=1050035. They > affect PLDHashTable's API in the following ways. > > - PLDHashTable now allocates its entry storage lazily. (nsTHashtable and > friends do too, s

Some more PLDHashTable API tweaks

2015-02-04 Thread Nicholas Nethercote
Hi, I just landed the patches in https://bugzilla.mozilla.org/show_bug.cgi?id=1050035. They affect PLDHashTable's API in the following ways. - PLDHashTable now allocates its entry storage lazily. (nsTHashtable and friends do too, since they are just layers on top of PLDHashTable.) This is a n