Re: reorganizing some test directories

2013-04-11 Thread Gregory Szorc
On 4/11/2013 1:57 AM, Neil wrote: > Gregory Szorc wrote: > >> We should eventually be able to get to a state where there are no >> moz.build/Makefile.in files in test directories. Well, at least for >> test suites using manifests to define test files (xpcshell, >> mochitest, reftest, possibly other

Re: reorganizing some test directories

2013-04-11 Thread Benjamin Smedberg
On 4/11/2013 11:47 AM, jmaher wrote: Great question- the main goal is to have each test type in a directory for that specific harness. Yes, but why is that a good thing? In general, I feel that our directory structures are way too deep already, and it would be better to make them as flat as po

Re: reorganizing some test directories

2013-04-11 Thread jmaher
On Thursday, April 11, 2013 10:26:25 AM UTC-4, Scott Johnson wrote: > Thus Spoke jmaher: > > > There are a couple common directory structures used for storing tests in > > the tree: > > > 1) /tests > > > 2) /tests/ > > > > > > I have a series of patches which will move most of the directory s

Re: reorganizing some test directories

2013-04-11 Thread Scott Johnson
Thus Spoke jmaher: > There are a couple common directory structures used for storing tests in the > tree: > 1) /tests > 2) /tests/ > > I have a series of patches which will move most of the directory structures > from #1 to a format of #2. This means we would see: > /tests/mochitest > /tests/bro

Re: reorganizing some test directories

2013-04-11 Thread Ms2ger
On 04/10/2013 09:07 PM, jmaher wrote: There are a couple common directory structures used for storing tests in the tree: 1) /tests 2) /tests/ I have a series of patches which will move most of the directory structures from #1 to a format of #2. This means we would see: /tests/mochitest /tests

Re: reorganizing some test directories

2013-04-11 Thread Neil
Gregory Szorc wrote: We should eventually be able to get to a state where there are no moz.build/Makefile.in files in test directories. Well, at least for test suites using manifests to define test files (xpcshell, mochitest, reftest, possibly others). Do these manifests include associated

Re: reorganizing some test directories

2013-04-10 Thread Gregory Szorc
On 4/10/2013 2:42 PM, Benoit Girard wrote: > With the fix to bug 844288 gtest will also need their own directory. I was > planning on allowing users to use /tests folder for their tests > but to go in line with this upcoming change I'll update my patches and > suggest that anyone who adds gtest to

Re: reorganizing some test directories

2013-04-10 Thread Benoit Girard
With the fix to bug 844288 gtest will also need their own directory. I was planning on allowing users to use /tests folder for their tests but to go in line with this upcoming change I'll update my patches and suggest that anyone who adds gtest to use /tests/gtest to conform with this new style. I