Masayuki Nakano wrote:
I have no idea why you thinks eventStructType should be only in debug
build.
Only because you mentioned that you were looking at possibly removing
it. If that happens, then I was suggesting it might be helpful to keep
around in debug builds for assertions like nsINode::
On 2013/10/26 12:47, Cameron McCormack wrote:
Tim Abraldes:
So my question is this; is it preferable to keep the As*Event
functions, or to use regular C++ casts to accomplish the same
behavior? We could use static_cast unconditionally for upcasts,
static_cast with a check of |eventStructType| fo
Tim Abraldes:
> > So my question is this; is it preferable to keep the As*Event
> > functions, or to use regular C++ casts to accomplish the same
> > behavior? We could use static_cast unconditionally for upcasts,
> > static_cast with a check of |eventStructType| for downcasts to
> > most-derived e
On 2013/10/25 6:39, Tim Abraldes wrote:
Finally, the root class, WidgetEvent, has As*Event class. The "*"
doesn't include the prefix. I.e., for WidgetMouseEvent, the method name
is WidgetEvent::AsMouseEvent(). This returns the pointer of the instance
only when the instance is the class or its der
> I hope this change makes you happy!
It most certainly does! I'm a huge proponent of code cleanup and organization,
and this looks like a beautiful example of those.
> Finally, the root class, WidgetEvent, has As*Event class. The "*"
> doesn't include the prefix. I.e., for WidgetMouseEvent, th
On 23/10/2013 09:18, Masayuki Nakano wrote:
I hope this change makes you happy!
It does - this is great stuff! Thank you for all your work on this!
--
Masayuki Nakano
Manager, Internationalization, Mozilla Japan.
___
dev-platform mailing list
de
On 2013-10-23 3:18 AM, Masayuki Nakano wrote:
I hope this change makes you happy!
Thanks for doing this!
Ehsan
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
7 matches
Mail list logo
