Re: Windows launcher process enabled by default on Nightly

2018-10-02 Thread Jean-Yves Avenard
Hi On 2/10/2018 5:05 AM, Aaron Klotz wrote: For various reasons we don't want to put escape hatches into any builds that we ship. For local builds, if it would ease developer concerns over this feature, we can look into it. I have filed bug 1495628 for that purpose. Seems that we can bui

Re: Windows launcher process enabled by default on Nightly

2018-10-01 Thread Aaron Klotz
On 9/28/2018 12:07 PM, Aaron Klotz wrote: On 9/27/2018 9:47 AM, Ted Mielczarek wrote: We have `MOZ_DEBUG_CHILD_PROCESS` for e10s content processes[1]. Would something similar (or maybe just supporting that?) be useful for the browser process as well? Sure, I have filed bug 1495039. The pat

Re: Windows launcher process enabled by default on Nightly

2018-10-01 Thread Aaron Klotz
On 10/1/2018 3:21 AM, Jean-Yves Avenard wrote: Can we have something to entirely disable that new feature such as ./mach run --disable-e10s that won't make firefox spawn another process? affects development/debugging process otherwise, not everyone use Visual Studio nor WinDbg for debugging pu

Re: Windows launcher process enabled by default on Nightly

2018-10-01 Thread Jean-Yves Avenard
Hi On 27/09/2018 5:19 PM, Aaron Klotz wrote: Hi everybody, Yesterday evening bug 1488554 [1] merged to mozilla-central, thus enabling the launcher process by default on Windows Nightly builds. This change is at the build config level. Can we have something to entirely disable that new feat

Re: Windows launcher process enabled by default on Nightly

2018-09-28 Thread Aaron Klotz
On 9/28/2018 12:10 PM, Ehsan Akhgari wrote: Is the --wait-for-browser flag the default in headless mode, since that mode is mostly for automation Good question. We already do that for --marionette, but not for headless. I have filed bug 1495049 to add this. Aaron ___

Re: Windows launcher process enabled by default on Nightly

2018-09-28 Thread Aaron Klotz
On 9/27/2018 1:53 PM, David Teller wrote: It sounds cool, but I'm trying to understand what it means :) Do I understand correctly that the main benefit is security? In its current form, there are currently two primary security benefits that the launcher process provides: * When the launcher

Re: Windows launcher process enabled by default on Nightly

2018-09-28 Thread Ehsan Akhgari
On Thu, Sep 27, 2018 at 11:19 AM Aaron Klotz wrote: > 1. Automation > - > > If you are doing some kind of automation that waits for the Firefox > process to finish, you'll find that the initial Firefox process exits > sooner than the browser, appearing to your script that Firefox is >

Re: Windows launcher process enabled by default on Nightly

2018-09-28 Thread Aaron Klotz
On 9/27/2018 9:47 AM, Ted Mielczarek wrote: We have `MOZ_DEBUG_CHILD_PROCESS` for e10s content processes[1]. Would something similar (or maybe just supporting that?) be useful for the browser process as well? Sure, I have filed bug 1495039. * If you use WinDbg, you may start your debuggi

Re: Windows launcher process enabled by default on Nightly

2018-09-27 Thread David Teller
Hi Aaron, It sounds cool, but I'm trying to understand what it means :) Do I understand correctly that the main benefit is security? Cheers, David On 27/09/2018 17:19, Aaron Klotz wrote: > Hi everybody, > > Yesterday evening bug 1488554 [1] merged to mozilla-central, thus > enabling the la

Re: Windows launcher process enabled by default on Nightly

2018-09-27 Thread Honza Bambas
On 2018-09-27 17:19, Aaron Klotz wrote: * If you use Visual Studio, you may install the Child Process Debugging Power Tool [3] which, once configured, will make the VS debugger automagically attach to the launcher's child processes. I'm using "Spawned Process Catcher X" that works better, but

Re: Windows launcher process enabled by default on Nightly

2018-09-27 Thread Ted Mielczarek
Hi Aaron, Great work getting this landed, and thanks for doing the work to minimize the impact on everyone! On Thu, Sep 27, 2018, at 11:19 AM, Aaron Klotz wrote: > 2. Debugging the browser process > > > If you launch Firefox via a debugger, the initial process w