Re: Splitting inner and outer windows

2016-01-30 Thread Johnny Stenback
\o/ This is a big deal, excellent to see this coming, and it's been a long time coming (since ~2004 when we first created the notion of inner and outer windows. Thanks for taking this on Kyle! - jst On Sat, Jan 30, 2016 at 4:04 PM, Kyle Huey wrote: > This has landed (and stuck) on inbound. > >

Re: Splitting inner and outer windows

2016-01-30 Thread Kyle Huey
This has landed (and stuck) on inbound. - Kyle On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > Early in the next release cycle I plan to land a patch that will remove > nsPIDOMWindow in favor of two separate types for inner and outer windows > (fittingly, called nsPIDOMWindowInner/nsPIDOMWi

Re: Splitting inner and outer windows

2016-01-22 Thread Kyle Huey
On Fri, Jan 22, 2016 at 11:24 AM, Bobby Holley wrote: > > > On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > >> Early in the next release cycle I plan to land a patch that will remove >> nsPIDOMWindow in favor of two separate types for inner and outer windows >> (fittingly, called nsPIDOMWind

Re: Splitting inner and outer windows

2016-01-22 Thread Bobby Holley
On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > Early in the next release cycle I plan to land a patch that will remove > nsPIDOMWindow in favor of two separate types for inner and outer windows > (fittingly, called nsPIDOMWindowInner/nsPIDOMWindowOuter) I'll also make > changes to the XPIDL

Re: Splitting inner and outer windows

2016-01-22 Thread Kyle Huey
They will continue to implement nsIDOMWindow just like they do nsIDOMWindowInternal. We're simply not going to use it for anything. - Kyle On Fri, Jan 22, 2016 at 7:53 AM, Dave Townsend wrote: > Does this mean that window objects will no longer implement > nsIDOMWindow (at least as far as JS i

Re: Splitting inner and outer windows

2016-01-22 Thread Dave Townsend
Does this mean that window objects will no longer implement nsIDOMWindow (at least as far as JS is concerned)? Querying for nsIDOMWindow is something add-ons do a lot and I'd expect to see a lot of add-ons break if we changed that. On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > Early in the