On Sun, Jul 1, 2018, at 7:56 PM, Xidorn Quan wrote:
> The point is that adding a new crate dependency is too easy
> accidentally, and it is very possible for reviewers to overlook that. So
> it may make sense to introduce a blacklist-ish thing to avoid that to
> happen.
FYI, we had some discuss
On Wed, Jun 27, 2018 at 5:02 AM, Adam Gashlin wrote:
> * Already vendored crates
> Can I assume any crates we have already in mozilla-central are ok to use?
Seems like a reasonable assumption.
> * Updates
> I need winapi 0.3.5 for BITS support, currently third_party/rust/winapi is
> 0.3.4. There
On Mon, Jul 2, 2018 at 4:05 PM, Lars Bergstrom wrote:
> Cool! I was just worried, especially since hyper and tokio/mio are
> *already* vendored in-tree (though openssl is not yet). It appears they're
> used for network access in some test tools and an audio ipc server
> prototype. So we're not ta
Cool! I was just worried, especially since hyper and tokio/mio are
*already* vendored in-tree (though openssl is not yet). It appears they're
used for network access in some test tools and an audio ipc server
prototype. So we're not talking about a bunch of code "appearing" in
third-party, but rath
I think the key distinction here is that, unlike other rust-based projects
(i.e. Servo), Firefox vendors all cargo dependencies into the tree, so it's
more obvious to reviewers when a patch indirectly pulls in a new large
dependency. In Servo the reviewer would have to look carefully at the
Cargo.l
On Sun, Jul 1, 2018 at 4:56 PM, Xidorn Quan wrote:
> On Mon, Jul 2, 2018, at 9:03 AM, Eric Rescorla wrote:
> > On Sat, Jun 30, 2018 at 9:35 AM, Lars Bergstrom
> > wrote:
> >
> > > On Fri, Jun 29, 2018 at 8:33 AM, Tom Ritter wrote:
> > >
> > > >
> > > > I know that enumerating badness is never a
On Mon, Jul 2, 2018, at 9:03 AM, Eric Rescorla wrote:
> On Sat, Jun 30, 2018 at 9:35 AM, Lars Bergstrom
> wrote:
>
> > On Fri, Jun 29, 2018 at 8:33 AM, Tom Ritter wrote:
> >
> > >
> > > I know that enumerating badness is never a comprehensive solution; but
> > > maybe there could be a wiki page
On Sat, Jun 30, 2018 at 9:35 AM, Lars Bergstrom
wrote:
>
>
> On Fri, Jun 29, 2018 at 8:33 AM, Tom Ritter wrote:
>
> >
> > I know that enumerating badness is never a comprehensive solution; but
> > maybe there could be a wiki page we could point people to for things that
> > indicate something
On Fri, Jun 29, 2018 at 8:33 AM, Tom Ritter wrote:
>
> I know that enumerating badness is never a comprehensive solution; but
> maybe there could be a wiki page we could point people to for things that
> indicate something is doing something scary in Rust? This might let us
> crowd-source the
On Thu, Jun 28, 2018 at 11:42 PM, Nathan Froyd wrote:
> We have generally trusted people to use good judgement in what they
> use and how much review is required. Accordingly, I think you should
> request review from the people who would normally review your code,
> and if you have concerns abou
On Thu, Jun 28, 2018 at 4:42 PM, Nathan Froyd wrote:
> Thanks for raising these points.
>
Thanks for the response!
On Tue, Jun 26, 2018 at 10:02 PM, Adam Gashlin wrote:
> > * Already vendored crates
> > Can I assume any crates we have already in mozilla-central are ok to use?
> > Last year the
Thanks for raising these points.
On Tue, Jun 26, 2018 at 10:02 PM, Adam Gashlin wrote:
> * Already vendored crates
> Can I assume any crates we have already in mozilla-central are ok to use?
> Last year there was a thread that mentioned making a list of "sanctioned"
> crates, did that ever come a
On Wed, Jun 27, 2018 at 12:42 PM Simon Sapin wrote:
> On 27/06/18 19:45, Bobby Holley wrote:
> > Hi Adam,
> >
> > At present, I think you should raise your questions with Nathan Froyd and
> > Ehsan Akhgari, who are the owners of the C++/Rust usage module [1].
> >
> > There has been some discussio
On 27/06/18 19:45, Bobby Holley wrote:
Hi Adam,
At present, I think you should raise your questions with Nathan Froyd and
Ehsan Akhgari, who are the owners of the C++/Rust usage module [1].
There has been some discussion around creating a Rust-in-Firefox Advisory
Committee to handle questions l
Hi Adam,
At present, I think you should raise your questions with Nathan Froyd and
Ehsan Akhgari, who are the owners of the C++/Rust usage module [1].
There has been some discussion around creating a Rust-in-Firefox Advisory
Committee to handle questions like this, but it hasn't happened yet. In
15 matches
Mail list logo
