Re: Revised proposal to refactor the observer service

2018-01-29 Thread Nathan Froyd
On Wed, Jan 17, 2018 at 10:47 AM, Gabriele Svelto wrote: > 1) Introduce a new observer service that would live alongside the > current one (nsIObserverService2?). This will use a machine-generated > list of topics that will be held within the interface itself instead of > a separate file as I orig

Re: Revised proposal to refactor the observer service

2018-01-29 Thread Gabriele Svelto
On 29/01/2018 10:54, Gijs Kruitbosch wrote: > FWIW, this plan seems great to me. Thanks for taking the time to revise > based on everybody's feedback! You're welcome! When doing changes that touch the entire codebase I believe it's critical to have everybody's feedback because it's impossible to b

Re: Revised proposal to refactor the observer service

2018-01-28 Thread Nicholas Nethercote
I have similar issues with some changes to prefs that I am planning. I too am probably going to end up with a split implementation, with "good prefs" (faster, better) for C++ usage and "crappy prefs" (the current implementation) for JS usage. https://bugzilla.mozilla.org/show_bug.cgi?id=1425909 is