Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Gregory Szorc
On 2/6/14, 11:34 AM, Dave Townsend wrote: I think perhaps I wasn't clear. I'd expect "getcwd() not in objdir nor srcdir" to have as the first option "look for the srcdir based on the location of the called mach script". So I can do "/mach" and have

Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Dave Townsend
On Thu, Feb 6, 2014 at 11:24 AM, Gregory Szorc wrote: > On 2/6/14, 11:21 AM, Dave Townsend wrote: > >> On Thu, Feb 6, 2014 at 10:57 AM, Gregory Szorc > > wrote: >> >> On 2/6/14, 9:23 AM, Dave Townsend wrote: >> >> I assume the second section is actually "getcw

Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Gregory Szorc
On 2/6/14, 11:21 AM, Dave Townsend wrote: On Thu, Feb 6, 2014 at 10:57 AM, Gregory Szorc mailto:g...@mozilla.com>> wrote: On 2/6/14, 9:23 AM, Dave Townsend wrote: I assume the second section is actually "getcwd() not in objdir but is in srcdir"? Yes.

Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Dave Townsend
On Thu, Feb 6, 2014 at 10:57 AM, Gregory Szorc wrote: > On 2/6/14, 9:23 AM, Dave Townsend wrote: > >> I assume the second section is actually "getcwd() not in objdir but is >> in srcdir"? >> > > Yes. > > > I'm crazy enough to want to be able to call mach when getcwd() isn't >> either the objdir

Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Gregory Szorc
On 2/6/14, 9:23 AM, Dave Townsend wrote: I assume the second section is actually "getcwd() not in objdir but is in srcdir"? Yes. I'm crazy enough to want to be able to call mach when getcwd() isn't either the objdir or srcdir. I have many of both and use various environment flags to say which

Re: Proposing changes to how mach does environment detection

2014-02-06 Thread Dave Townsend
I assume the second section is actually "getcwd() not in objdir but is in srcdir"? I'm crazy enough to want to be able to call mach when getcwd() isn't either the objdir or srcdir. I have many of both and use various environment flags to say which is active currently. Perhaps it's implicit, but I

Re: Proposing changes to how mach does environment detection

2014-02-05 Thread Gavin Sharp
Whose workflow requires calling mach not in an objdir or srcdir? That seems crazy and no one should do it! Similarly, it seems like all of the ambiguous cases you mention should be aborts, because I don't know of any reasonable cases where someone would be in that situation, and "picking one" just