Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-15 Thread Ehsan Akhgari
On 09/14/2017 05:37 PM, Boris Zbarsky wrote: On 9/14/17 5:33 PM, Ehsan Akhgari wrote: I think either of these two ideas would be good, but I think unshipping in 57 is premature without having an understanding of how much the Web depends on this for UA sniffing. OK. Do you have any suggestions

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-14 Thread Boris Zbarsky
On 9/14/17 5:47 PM, Kris Maglione wrote: Could we make it non-enumerable and add a counter to the window binding resolve hook? We could. Note that it would also trigger on sets of "window.content" or on "var content" and so forth, though... Not clear how useful the resulting data would be,

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-14 Thread Kris Maglione
On Thu, Sep 14, 2017 at 05:37:58PM -0400, Boris Zbarsky wrote: On 9/14/17 5:33 PM, Ehsan Akhgari wrote: I think either of these two ideas would be good, but I think unshipping in 57 is premature without having an understanding of how much the Web depends on this for UA sniffing. OK. Do you ha

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-14 Thread Boris Zbarsky
On 9/14/17 5:33 PM, Ehsan Akhgari wrote: I think either of these two ideas would be good, but I think unshipping in 57 is premature without having an understanding of how much the Web depends on this for UA sniffing. OK. Do you have any suggestions on how we could gain that understanding? We

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-14 Thread Ehsan Akhgari
On 09/13/2017 10:34 AM, Mike Taylor wrote: On 9/12/17 5:04 PM, Boris Zbarsky wrote: We could also delay the removal to after 57 to mitigate 57 risk Or remove it for non-RELEASE_OR_BETA builds for a release or two to see what shakes out in Nightly/DevEdition reports. I think either of these

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-13 Thread Mike Taylor
On 9/12/17 5:04 PM, Boris Zbarsky wrote: > We could also delay the removal to after 57 to mitigate 57 risk Or remove it for non-RELEASE_OR_BETA builds for a release or two to see what shakes out in Nightly/DevEdition reports. -- Mike Taylor Web Compat, Mozilla

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-12 Thread Boris Zbarsky
On 9/12/17 5:04 PM, Emilio Cobos Álvarez wrote: I've noticed that this may be used pretty easily for UA detection. Right, that and use in Gecko-only codepaths are the main concerns I considered adding a usecounter, but as you noted it would be affected by window enumeration. We could ma

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-12 Thread Kohei Yoshino
A similar story: `window.controllers` was removed with Firefox 29 but added back to Firefox 30 because it had been widely used for UA detection. `window.content` might cause the same compatibility issue, but anyway, it's difficult to guess the impact from GitHub search results... https://www.f

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-12 Thread Emilio Cobos Álvarez
Just for the record, since I got curious and I saw no mention in the intent email: I've noticed that this may be used pretty easily for UA detection. So far [1] is the only remotely related thing I've found from a search on Google and GitHub (outside of the firefox codebase ofc). I suspect keepin