Re: Experimenting with a shared review queue for Core::Build Config

2017-10-31 Thread Mark Banner
On 11/10/2017 19:41, Botond Ballo wrote: On Wed, Oct 11, 2017 at 2:37 PM, Chris Cooper wrote: On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: Does this user have a bugzilla :alias so that folks submitting patches via MozReview or similar can just write r=build-peer or something, rather t

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-13 Thread Nicholas Alexander
On Fri, Oct 13, 2017 at 7:47 AM, Andreas Tolfsen wrote: > Also sprach smaug: > > How did the setup actually work? >> > > I think farre gave a satisfactory summary of the review tool above. > > I've asked this from farre too before, and IIRC, the reply was >> that is wasn't working that well. Cert

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-13 Thread Andreas Tolfsen
Also sprach smaug: How did the setup actually work? I think farre gave a satisfactory summary of the review tool above. I've asked this from farre too before, and IIRC, the reply was that is wasn't working that well. Certain devs still ended up doing majority of the reviews. But perhaps I m

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread smaug
On 10/11/2017 09:55 PM, Andreas Tolfsen wrote: +tools-marionette Also sprach Chris Cooper: Many of the build peers have long review queues. Is having a long review queue the actual issue? Isn't (too) high throughput at least equally bad issue. Does the new setup somehow try to ensure reviews

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Andreas Tolfsen
+tools-marionette Also sprach Chris Cooper: Many of the build peers have long review queues. I'm not convinced that all of the review requests going to any particular build peer need to be exclusive. I think it is great that you’re experimenting with this, and I’m very excited about it! In a

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Botond Ballo
On Wed, Oct 11, 2017 at 2:37 PM, Chris Cooper wrote: > On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: >> Does this user have a bugzilla :alias so that folks submitting patches >> via MozReview or similar can just write r=build-peer or something, >> rather than having to manually select the

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Chris Cooper
On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: > Does this user have a bugzilla :alias so that folks submitting patches > via MozReview or similar can just write r=build-peer or something, > rather than having to manually select the appropriate shared queue > after submitting their patch for

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Nathan Froyd
Does this user have a bugzilla :alias so that folks submitting patches via MozReview or similar can just write r=build-peer or something, rather than having to manually select the appropriate shared queue after submitting their patch for review? -Nathan On Wed, Oct 11, 2017 at 1:41 PM, Chris Coop