Re: Does mozilla allow modification of Strings

2019-02-01 Thread Kris Maglione
On Tue, Jan 29, 2019 at 02:08:59AM -0800, Nanday Dan wrote: On Tuesday, January 29, 2019 at 12:22:08 AM UTC+5:30, Kris Maglione wrote: >Is it possible to add an extra variable to mozilla string(nsTStringRepr). > > >I added a bool variable to nsTStringRepr class in Xpcom/Strings/ As something

Re: Does mozilla allow modification of Strings

2019-01-31 Thread Nanday Dan
On Monday, January 28, 2019 at 6:35:30 PM UTC+5:30, Emilio Cobos Álvarez wrote: > There are probably two different issues. > > On 1/28/19 1:51 PM, wrote: > > > > > > Is it possible to add an extra variable to mozilla string(nsTStringRepr). > > > > > > I added a bool variable to nsTStrin

Re: Does mozilla allow modification of Strings

2019-01-29 Thread Boris Zbarsky
On 1/29/19 4:37 AM, Nanday Dan wrote: I added the variable to FakeString. But still application crashes. Sure, unless you also fixed the Rust interop issue. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.or

Re: Does mozilla allow modification of Strings

2019-01-29 Thread Nanday Dan
On Tuesday, January 29, 2019 at 12:22:08 AM UTC+5:30, Kris Maglione wrote: > >Is it possible to add an extra variable to mozilla string(nsTStringRepr). > > > > > >I added a bool variable to nsTStringRepr class in Xpcom/Strings/ > > As something of a side note, the general way to do this is to >

Re: Does mozilla allow modification of Strings

2019-01-29 Thread Nanday Dan
On Monday, January 28, 2019 at 9:09:05 PM UTC+5:30, Boris Zbarsky wrote: > On 1/28/19 10:30 AM, Nanday Dan wrote: > > Sorry, I forgot to mention that I commented those lines too. > > If you comment those lines, you will likely end up with code reading > random values for your boolean at best and

Re: Does mozilla allow modification of Strings

2019-01-28 Thread Kris Maglione
On Mon, Jan 28, 2019 at 04:51:12AM -0800, edusubscr...@gmail.com wrote: Is it possible to add an extra variable to mozilla string(nsTStringRepr). I added a bool variable to nsTStringRepr class in Xpcom/Strings/ As something of a side note, the general way to do this is to add a new data or

Re: Does mozilla allow modification of Strings

2019-01-28 Thread Kris Maglione
On Mon, Jan 28, 2019 at 02:05:18PM +0100, Emilio Cobos Álvarez wrote: There are probably two different issues. On 1/28/19 1:51 PM, edusubscr...@gmail.com wrote: Is it possible to add an extra variable to mozilla string(nsTStringRepr). I added a bool variable to nsTStringRepr class

Re: Does mozilla allow modification of Strings

2019-01-28 Thread Boris Zbarsky
On 1/28/19 10:30 AM, Nanday Dan wrote: Sorry, I forgot to mention that I commented those lines too. If you comment those lines, you will likely end up with code reading random values for your boolean at best and crashing at worst (if you added the boolean at the end; if not, it's just all goi

Re: Does mozilla allow modification of Strings

2019-01-28 Thread Boris Zbarsky
On 1/28/19 7:51 AM, edusubscr...@gmail.com wrote: Building was successful. I'm really surprised the static assert at https://searchfox.org/mozilla-central/rev/4faab2f1b697827b93e16cb798b22b197e5235c9/dom/bindings/FakeString.h#146-147 did not trigger, given the changes you described... -Bori

Re: Does mozilla allow modification of Strings

2019-01-28 Thread Emilio Cobos Álvarez
There are probably two different issues. On 1/28/19 1:51 PM, edusubscr...@gmail.com wrote: > > > Is it possible to add an extra variable to mozilla string(nsTStringRepr). > > > I added a bool variable to nsTStringRepr class in Xpcom/Strings/ > > While building the build I got stati