Re: DXR UI refresh is live!

On 2/11/2014 5:00 PM, Ehsan Akhgari wrote: I don't think any of these are important features for us to focus on. I would say that we accept patches for the last three items, but I don't think we are interested in accepting patches for CVS support into DXR. This statement is worth slightly

Re: DXR UI refresh is live!

Very happy now :) Erik Rose Tuesday, February 11, 2014 14:50 I believe this is fixed now, a casualty of a needless use of JS, which is now gone. If you still see this behavior, please reopen https://bugzilla.mozilla.org/show_bug.cgi?id=965659. Thanks for riding out

Re: DXR UI refresh is live!

On 2/11/2014, 3:18 PM, Reed Loden wrote: On Fri, 7 Feb 2014 16:26:19 -0500 Erik Rose wrote: https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/ Happy hacking! I do like the slickness and quickness, but it still seems greatly-lacking usability-wise (as compared to mxr)...

Re: DXR UI refresh is live!

> that's pretty, but where did the list of classes & class members go when > viewing files like > http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp I believe this is fixed now, a casualty of a needless use of JS, which is now gone. If you still see this behavior, ple

Re: DXR UI refresh is live!

Hi, Reed. Rest assured, many of your wishes are planned for the future. But when you have a big project, you've got to pick some things. Last week's release was an important milestone: it was the minimal feature set that would yield a cohesive experience under a UI new design. The new design so

Re: DXR UI refresh is live!

On Wed, Feb 12, 2014 at 9:18 AM, Reed Loden wrote: > I do like the slickness and quickness, but it still seems > greatly-lacking usability-wise (as compared to mxr)... > > A few things off the top of my head: > * Where are the non-mozilla-central repositories? > * Where's the integration with CVS

Re: DXR UI refresh is live!

On Fri, 7 Feb 2014 16:26:19 -0500 Erik Rose wrote: > https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/ > > Happy hacking! I do like the slickness and quickness, but it still seems greatly-lacking usability-wise (as compared to mxr)... A few things off the top of my head: *

Re: DXR UI refresh is live!

> Why are you double spacing the output and then "fixing" it by hard-coding .7 > line spacing for the source and 1.4 for the line numbers? That was weird. Nobody knew why. Fixed now: https://github.com/mozilla/dxr/commit/16784204ce30c428cc3e325d7f5ccd225346bfdf. This also makes copying and past

Re: DXR UI refresh is live!

Edwin Flores wrote: the "click here to view all search results" link I wondered what this was, but it turns out I had disabled JavaScript in that browser. -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozi

Re: DXR UI refresh is live!

>> I notice the "click here to view all search results" link is at the top >> of the code listing now, instead of being with the search bar. That >> means it'll be invisible most of the time. > > First, let me say that we're still moving error messages around. We'll > probably end up with somethi

Re: DXR UI refresh is live!

> I notice the "click here to view all search results" link is at the top > of the code listing now, instead of being with the search bar. That > means it'll be invisible most of the time. First, let me say that we're still moving error messages around. We'll probably end up with something like t

Re: DXR UI refresh is live!

On 08/02/14 10:26, Erik Rose wrote: > https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/ > > Happy hacking! Looks awesome! But... (there's always a but) I notice the "click here to view all search results" link is at the top of the code listing now, instead of being with the

Re: DXR UI refresh is live!

Erik Rose wrote: https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/ Why are you double spacing the output and then "fixing" it by hard-coding .7 line spacing for the source and 1.4 for the line numbers? Also although most of your CSS uses classes, some of it uses :firs

Re: DXR UI refresh is live!

Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=969887#c1. It will take effect with the next re-index, in a few hours. Good eye! Somehow, nobody caught this on staging or locally, though it seems obvious in retrospect. While I was at it, I stopped the code from jumping to the side when you

Re: DXR UI refresh is live!

The design looks really fresh, I really like the new colors. I am however wondering about additional spaces that were introduced, they seem to even break indentation: http://dxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1426. -Tom On Sat, Feb 8, 2014 at 1:29 AM, Erik Rose wrote: > >

Re: DXR UI refresh is live!

> that's pretty, but where did the list of classes & class members go when > viewing files like > http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp Coming back soon: https://bugzilla.mozilla.org/show_bug.cgi?id=965659. We're having some trouble reducing it to a test

Re: DXR UI refresh is live!

that's pretty, but where did the list of classes & class members go when viewing files like http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp - Original Message - > From: "Erik Rose" > To: dev-platform@lists.mozilla.org, dev-static-analy...@lists.mozilla.org