Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Jeff Gilbert
Notably, aFoo is neither Google nor Rust style. If we didn't already have aFoo as a style, we certainly wouldn't adopt it today. On Fri, Sep 6, 2019 at 6:59 AM Botond Ballo wrote: > On Fri, Sep 6, 2019 at 9:40 AM Andrew Sutherland > wrote: > > But of course, if this was all being done from insi

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Botond Ballo
On Fri, Sep 6, 2019 at 9:40 AM Andrew Sutherland wrote: > But of course, if this was all being done from inside an editor or a > debugger, no matter what tricks searchfox can do, they can't help you > elsewhere. Editors can of course do things of their own to help you on this front. For example,

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread David Teller
I'm sure that Searchfox could have useful highlights. However, as you guessed, this was something that happened within an editor + debugger, so there's only so much we can do in this direction. Cheers, David On 06/09/2019 15:40, Andrew Sutherland wrote: > On 9/6/19 7:31 AM, David Teller wrote:

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Andrew Sutherland
On 9/6/19 7:31 AM, David Teller wrote: For what it's worth, I recently spent half a day attempting to solve a bug which would have been trivial if `a` and `m` prefixes had been present in that part of the code. While I find these notations ugly, they're also useful. Is this something searchfo

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread David Teller
For what it's worth, I recently spent half a day attempting to solve a bug which would have been trivial if `a` and `m` prefixes had been present in that part of the code. While I find these notations ugly, they're also useful. Cheers, David On 06/09/2019 12:57, Honza Bambas wrote: > On 2019-09

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Honza Bambas
On 2019-09-05 23:14, Emilio Cobos Álvarez wrote: Yeah, let's not add a new prefix please. I don't like aFoo either, though it's everywhere so consistency is better than nothing :/. That being said, it shouldn't be hard to write some clang plugin or such that automatically renames function ar

Re: Coding style: Naming parameters in lambda expressions

2019-09-05 Thread Emilio Cobos Álvarez
Yeah, let's not add a new prefix please. I don't like aFoo either, though it's everywhere so consistency is better than nothing :/. That being said, it shouldn't be hard to write some clang plugin or such that automatically renames function arguments to stop using aFoo, should we want to do

Re: Coding style: Naming parameters in lambda expressions

2019-09-05 Thread Jeff Gilbert
I remain against aFoo style. I still think it's low-signal-high-noise, and doesn't provide value that modern syntax highlighting doesn't provide for those who find it useful. I'm absolutely opposed to adding a new prefix. That would be moving even further down the path of our proprietary code-smel