Re: Changes to how EXPORTS are handled

2013-09-05 Thread Neil
Mike Hommey wrote: On Wed, Sep 04, 2013 at 11:35:19AM -0700, Gregory Szorc wrote: It's worth explicitly mentioning that tiers limit the ability of the build system to build concurrently. So, we have to choose between speed and a moving/complex target of "dependency correctness." We have ch

Re: Changes to how EXPORTS are handled

2013-09-04 Thread Mike Hommey
On Wed, Sep 04, 2013 at 11:35:19AM -0700, Gregory Szorc wrote: > On 9/4/13 3:04 AM, Mike Hommey wrote: > >On Wed, Sep 04, 2013 at 10:57:26AM +0100, L. David Baron wrote: > >>>The way the tier build works is that we effectively make export in all > >>>directories of a same tier before make libs. In

Re: Changes to how EXPORTS are handled

2013-09-04 Thread Gregory Szorc
On 9/4/13 3:04 AM, Mike Hommey wrote: On Wed, Sep 04, 2013 at 10:57:26AM +0100, L. David Baron wrote: The way the tier build works is that we effectively make export in all directories of a same tier before make libs. In practice, this means xpcom had access to every header in platform already,

Re: Changes to how EXPORTS are handled

2013-09-04 Thread Mike Hommey
On Wed, Sep 04, 2013 at 10:57:26AM +0100, L. David Baron wrote: > > The way the tier build works is that we effectively make export in all > > directories of a same tier before make libs. In practice, this means > > xpcom had access to every header in platform already, and any tier built > > before

Re: Changes to how EXPORTS are handled

2013-09-04 Thread L. David Baron
On Wednesday 2013-09-04 18:45 +0900, Mike Hommey wrote: > On Wed, Sep 04, 2013 at 10:28:21AM +0100, L. David Baron wrote: > > On Wednesday 2013-09-04 00:31 -0700, Gregory Szorc wrote: > > > Assuming it sticks, bug 896797 just landed in inbound and changes > > > how EXPORTS/headers are installed. Th

Re: Changes to how EXPORTS are handled

2013-09-04 Thread Mike Hommey
On Wed, Sep 04, 2013 at 10:28:21AM +0100, L. David Baron wrote: > On Wednesday 2013-09-04 00:31 -0700, Gregory Szorc wrote: > > Assuming it sticks, bug 896797 just landed in inbound and changes > > how EXPORTS/headers are installed. This may impact your developer > > workflow if you modify EXPORTS

Re: Changes to how EXPORTS are handled

2013-09-04 Thread L. David Baron
On Wednesday 2013-09-04 00:31 -0700, Gregory Szorc wrote: > Assuming it sticks, bug 896797 just landed in inbound and changes > how EXPORTS/headers are installed. This may impact your developer > workflow if you modify EXPORTS in a moz.build file to add/remove > headers. > > Previously, headers we

Re: Changes to how EXPORTS are handled

2013-09-04 Thread Mike Hommey
On Wed, Sep 04, 2013 at 12:31:02AM -0700, Gregory Szorc wrote: > Assuming it sticks, bug 896797 just landed in inbound and changes > how EXPORTS/headers are installed. This may impact your developer > workflow if you modify EXPORTS in a moz.build file to add/remove > headers. > > Previously, heade