Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-29 Thread Tooru Fujisawa
thanks for the input :) re-landed them disabling on chrome/addon, with a test that checks they're not available on chrome code. -- arai > 2017/03/28 1:38、Shu-yu Guo のメール: > > Cross-posting to firefox-dev. > > TL;DR: > > arai has done truly excellent feature work implementing the ECMAScript

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread Ryan VanderMeulen
Let's make sure to add a test that's expected to fail as well for this so we can verify that we don't accidentally ship this enabled in chrome. Not that we've had any recent instances of thinking we'd disabled a feature only for it to get unknowingly shipped :) -Ryan On 3/27/2017 12:31 PM, Sh

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread Shu-yu Guo
I agree that disabling for chrome is the right thing here over prefs. I want Nightly and DevEdition to have stage 3+ TC39 proposals unflagged and ready to play with -- asking folks to turn on prefs to do that is not the way to go here from my perspective. Benjamin's concern is legit, though, so le

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread Shu-yu Guo
Cross-posting to firefox-dev. TL;DR: arai has done truly excellent feature work implementing the ECMAScript Async Iteration proposal. It is gated to Nightly/DevEd only for content code. We will also be turning off the feature in chrome code to prevent accidental dependence. Both these restriction

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread Till Schneidereit
I think disabling in chrome code is a good idea. We have done these kinds of non-release-only features in the JS engine in the past, and it hasn't always gone well precisely for the reasons that have you concerned. OTOH, adding a pref is annoyingly complicated for JS engine features (we should prob

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread zbraniecki
That's super exciting! The new localization resources registry module is being written with async generators in mind. I have the patch ready in the bug, which can be flipped to go async with 8 lines of code. I know we're not planning to make it ride trains just yet, but if you need a real-worl

Re: Async Iteration is available on non-release-only, for testing purpose

2017-03-27 Thread Benjamin Smedberg
I am concerned about the accidental consequences of turning this on for nightly/aurora. What if we start writing browser code that relies on these features which unexpectedly starts failing in beta? I presume the value of enabling this in nightly/aurora is that we can get web developers to experim