Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-13 Thread Andrew Sutherland
On 11/12/2013 03:39 AM, Henri Sivonen wrote: On Mon, Nov 11, 2013 at 10:08 PM, Andrew Sutherland wrote: On 11/11/2013 01:33 PM, Joshua Cranmer 🐧 wrote: Actually, I believe you need to keep the x-imap4-modified-utf7 converters in B2G, if you don't want to break Gaia Email's tests. They use the

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-12 Thread Neil
Mike Hommey wrote: Thunderbird is already linking stuff in libxul from c-c. Why wouldn't it be possible to move those bits to c-c and do the same? It's compiling components using the internal API and linking them into libxul because originally the mailnews components didn't compile against

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-12 Thread Henri Sivonen
On Mon, Nov 11, 2013 at 6:24 PM, Benjamin Smedberg wrote: > Why don't we remove them from core and let tbird devs deal with it when they > do have time (or stop supporting UTF7 and so forth if it's not important > enough to fix)? Removing the IMAP flavor of UTF-7 would break IMAP. I think it woul

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Mike Hommey
On Mon, Nov 11, 2013 at 05:23:48PM +0200, Henri Sivonen wrote: > We are building and shipping character encoding converters that are > dead code in Firefox but that are used in Thunderbird. Considering the > Firefox binary size, it seems like a bad idea to ship to dead code in > Firefox. > > Curre

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Andrew Sutherland
On 11/11/2013 01:33 PM, Joshua Cranmer 🐧 wrote: By far the easiest solution would be leaving the code in m-c but #ifdefing it out of Firefox builds. Is there a compelling reason not to do so? If there is no compelling reason against #ifdefing it out in m-c, what's the right variable to #ifdef on

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Joshua Cranmer 🐧
On 11/11/2013 9:23 AM, Henri Sivonen wrote: We are building and shipping character encoding converters that are dead code in Firefox but that are used in Thunderbird. Considering the Firefox binary size, it seems like a bad idea to ship to dead code in Firefox. Currently, this includes the encod

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Gabriele Svelto
On 11/11/2013 17:24, Benjamin Smedberg wrote: I'm not certain whether tbird (and seamonkey) are currently using a shared XULRunner in Linux distros. If they are, then this approach won't work well (we'd at least have to continue disabling these encodings via prefs in Firefox). I did a quick che

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Benjamin Smedberg
On 11/11/2013 10:23 AM, Henri Sivonen wrote: In principle, the right way to deal with this would be moving code to comm-central. However, this would involve annoyances like setting up a new XPCOM component there and making sure the category manager merges m-c-defined and c-c-defined category entr