Re: Proposal: Replace NS_ASSERTION with MOZ_ASSERT and then remove it.

2019-10-30 Thread Bobby Holley
On Wed, Oct 30, 2019 at 8:47 AM Nathan Froyd wrote: > On Wed, Oct 30, 2019 at 11:36 AM Tom Ritter wrote: > > > > I will claim that the most common behavior of developers is to leave > > XPCOM_DEBUG_BREAK alone and not set it to any particular value. I bet > most > > people haven't even heard of

Re: Proposal: Replace NS_ASSERTION with MOZ_ASSERT and then remove it.

2019-10-30 Thread Nathan Froyd
On Wed, Oct 30, 2019 at 11:36 AM Tom Ritter wrote: > > I will claim that the most common behavior of developers is to leave > XPCOM_DEBUG_BREAK alone and not set it to any particular value. I bet most > people haven't even heard of this or know what it does. > > With that env var unset, in Debug m

Proposal: Replace NS_ASSERTION with MOZ_ASSERT and then remove it.

2019-10-30 Thread Tom Ritter
I will claim that the most common behavior of developers is to leave XPCOM_DEBUG_BREAK alone and not set it to any particular value. I bet most people haven't even heard of this or know what it does. With that env var unset, in Debug mode, NS_ASSERTION will print to stderr and otherwise do nothing