Re: Problem with batch logging

2014-10-29 Thread Josip Maras
Hi, Mike, Ehsan, and David, thank you! In the end, I added the Logging functionality to mozglue, exported it, and imported it wherever necessary. Now it works as expected, and there are no noticeable hangings even when working with large applications (e.g. facebook). Just in case, if a begin

Re: Problem with batch logging

2014-10-28 Thread Mike Hommey
On Wed, Oct 29, 2014 at 08:08:23AM +0900, Mike Hommey wrote: > On Tue, Oct 28, 2014 at 11:56:49AM -0400, Ehsan Akhgari wrote: > > On 2014-10-28 4:16 AM, Josip Maras wrote: > > >Hi Ehsan, > > > > > >Yes, in my opinion that is the problem. I'm trying to use the global > > >stream variable across mod

Re: Problem with batch logging

2014-10-28 Thread Mike Hommey
On Tue, Oct 28, 2014 at 11:56:49AM -0400, Ehsan Akhgari wrote: > On 2014-10-28 4:16 AM, Josip Maras wrote: > >Hi Ehsan, > > > >Yes, in my opinion that is the problem. I'm trying to use the global stream > >variable across module boundaries, more specifically from the following > >source files: co

Re: Problem with batch logging

2014-10-28 Thread Ehsan Akhgari
On 2014-10-28 4:16 AM, Josip Maras wrote: Hi Ehsan, Yes, in my opinion that is the problem. I'm trying to use the global stream variable across module boundaries, more specifically from the following source files: content\base\src\Element.cpp; layout\style\nsCSSParser.cpp; content\base\src\ns

Re: Problem with batch logging

2014-10-28 Thread David Rajchenbach-Teller
On 28/10/14 09:35, Josip Maras wrote: > > Thanks for the tip. Can you perhaps drop the internal stream class names, so > I can investigate a bit on how to use them. > > Thank you! You may want to open an nsAtomicFileOutputStream on a thread: http://dxr.mozilla.org/mozilla-central/source/netwe

Re: Problem with batch logging

2014-10-28 Thread Josip Maras
Thanks for the tip. Can you perhaps drop the internal stream class names, so I can investigate a bit on how to use them. Thank you! On Friday, October 24, 2014 4:56:07 PM UTC+2, David Rajchenbach-Teller wrote: > Well, for one thing, never perform I/O on the main thread. It really > kills perfor

Re: Problem with batch logging

2014-10-28 Thread Josip Maras
Hi Ehsan, Yes, in my opinion that is the problem. I'm trying to use the global stream variable across module boundaries, more specifically from the following source files: content\base\src\Element.cpp; layout\style\nsCSSParser.cpp; content\base\src\nsINode.cpp, js\src\builtin\Eval.cpp, js\src\

Re: Problem with batch logging

2014-10-24 Thread Ehsan Akhgari
It's hard to determine exactly what's happening because your post doesn't explain where you're using this variable, but note that extern variables cannot be used across module boundaries. For example, nsBrowserApp.cpp get compiled into firefox.exe, whereas most of our code gets compiled in xul

Re: Problem with batch logging

2014-10-24 Thread David Rajchenbach-Teller
Well, for one thing, never perform I/O on the main thread. It really kills performance, as you witness. No amount of batching is going to be sufficient. Also, why don't you use our stream classes? Cheers, David On 24/10/14 14:36, Josip Maras wrote: > Hi, > > I'm extending the Firefox source in

Problem with batch logging

2014-10-24 Thread Josip Maras
Hi, I'm extending the Firefox source in order to log some information during web app execution, for example event, script executions, new element creations, removals, attribute modifications, etc. Since these things occur often, when I load a more demanding application (e.g. facebook), everythi