Re: Prefs overhaul

2018-03-12 Thread Nicholas Nethercote
The old code read the entire file into memory before starting parsing. In one place it did this with URLPreloader::ReadZip() (for default pref files), and in another place it did this with URLPreloader::ReadFile() (for user pref files). It was simplest to leave that code unchanged. Nick On Mon,

Re: Prefs overhaul

2018-03-12 Thread David Teller
Out of curiosity, why is the read handled by C++ code? On 12/03/2018 10:38, Nicholas Nethercote wrote: > I don't know. But libpref's file-reading is done by C++ code, which passes > a string to the Rust code for parsing. > > Nick > ___ > dev-platform ma

Re: Prefs overhaul

2018-03-12 Thread Nicholas Nethercote
On Sun, Mar 11, 2018 at 4:24 AM, ISHIKAWA,chiaki wrote: > > I have noticed that you mentioned rewrite in Rust. > > Does the I/O primitive Rust uses handle the following "short read" case > niciely? > I don't know. But libpref's file-reading is done by C++ code, which passes a string to the Rust

Re: Prefs overhaul

2018-03-10 Thread ISHIKAWA,chiaki
On 2018/03/07 12:08, Nicholas Nethercote wrote: Hi, I've been doing a lot of work to improve libpref recently, and there is more in the pipeline. I've written a brief roadmap that might be of interest to people: https://wiki.mozilla.org/Platform/PrefsOverhaul I'd be happy to hear feedback, via

Re: Prefs overhaul

2018-03-08 Thread Bobby Holley
This looks like great work - I'm very glad to see us investing in improvements to core infrastructure like this. Thanks Nick! On Tue, Mar 6, 2018 at 7:08 PM, Nicholas Nethercote wrote: > Hi, > > I've been doing a lot of work to improve libpref recently, and there is > more in the pipeline. I've

Re: Prefs overhaul

2018-03-07 Thread Kris Maglione
On Wed, Mar 07, 2018 at 02:08:59PM +1100, Nicholas Nethercote wrote: Hi, I've been doing a lot of work to improve libpref recently, and there is more in the pipeline. I've written a brief roadmap that might be of interest to people: https://wiki.mozilla.org/Platform/PrefsOverhaul I'd be happy t

Prefs overhaul

2018-03-06 Thread Nicholas Nethercote
Hi, I've been doing a lot of work to improve libpref recently, and there is more in the pipeline. I've written a brief roadmap that might be of interest to people: https://wiki.mozilla.org/Platform/PrefsOverhaul I'd be happy to hear feedback, via this list or other means. Thanks. Nick __