Re: PSA: RIP MOZ_ASSUME_UNREACHABLE

2014-09-22 Thread Benoit Jacob
Great work Chris! Thanks for linking to the study; the link gives me error 400, github links are tricky: 2014-09-22 4:06 GMT-04:00 Chris Peterson : > [1] https://raw.githubusercontent.com/bjacob/builtin-unreachable-study > Repo link: https://github.com/bjacob/builtin-unreachable-study Notes file

PSA: RIP MOZ_ASSUME_UNREACHABLE

2014-09-22 Thread Chris Peterson
MFBT's MOZ_ASSUME_UNREACHABLE macro has been removed. People mistakenly used it as a debug assertion, but it was actually a compiler optimization hint that invoked possibly dangerous undefined behavior if actually hit. For example, Benoit Jacob's detailed tests [1] show that gcc 4.6 can generat