Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Andrew Halberstadt
On 06/05/15 10:24 AM, Gijs Kruitbosch wrote: Do I need to pass flavor? What would happen if I do: ./mach mochitest path/to/dir/with/only/mochitest-browser/things -- would that "just work" ? Yep that should just work. Fyi, |mach mochitest| already exists, so you can do this now if you want. W

Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Gijs Kruitbosch
On 06/05/2015 15:14, Andrew Halberstadt wrote: Yeah, you shouldn't notice any difference when running from mach. The only change is that the harness is handling defaults instead of the mach command, and that they now both have the same command line. I think what you are thinking of is when you ru

Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Andrew Halberstadt
On 06/05/15 09:59 AM, Gijs Kruitbosch wrote: On 06/05/2015 14:33, Andrew Halberstadt wrote: 2) --close-when-done is now the default, so this option has been removed. Use --keep-open to turn it off. It was a pain to get this right for people's expectations when I messed with this - mochitest-br

Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Gijs Kruitbosch
On 06/05/2015 14:33, Andrew Halberstadt wrote: 2) --close-when-done is now the default, so this option has been removed. Use --keep-open to turn it off. It was a pain to get this right for people's expectations when I messed with this - mochitest-browser and mochitest-plain behave differently.

PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Andrew Halberstadt
As part of a cleanup of the mochitest harness and the mochitest mach command, the following arguments have changed in the harness (behaviour should be unchanged when running from mach): 1) --autorun is now the default so this option has been removed. Use --no-autorun to turn it off. 2) --clo