Re: Off-main-thread Painting

2013-02-14 Thread L. David Baron
On Monday 2013-02-11 23:21 -0800, Matt Woodrow wrote: > As an effort to improve both performance and responsiveness of the > browser, we are planning on moving painting to happen on a > separate thread. > > My initial draft plan to do this can be found here: > https://wiki.mozilla.org/Gecko:OffMai

Re: Off-main-thread Painting

2013-02-13 Thread Milan Sreckovic
That's a good point. The plan is to finish the layers refactoring landing by the week of March 18th. I didn't realize that anybody was looking at OMT painting right now. This was identified as something that needs to be done, together with OMT texture updates, removal of non-OMT code, etc.,

Re: Off-main-thread Painting

2013-02-13 Thread Chris Lord
On 12 February 2013 21:57:53, Clint Talbert wrote: I agree in part with the assertion about testing - that the existing reftests will catch most regressions stemming from this. But I think we also need some measurements around scrolling/responsiveness in order to verify that off main thread

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 12:28 PM, Matt Woodrow wrote: > This is the second half of the plan. Third paragraph of 'Proposed Solution' > > The basic idea is that the display list owned by the painting thread > already contains all the information required to render the page at any > scroll position.

Re: Off-main-thread Painting

2013-02-12 Thread Matt Woodrow
PM Subject: Re: Off-main-thread Painting On 13/02/13 09:52, Robert O'Callahan wrote: > On Wed, Feb 13, 2013 at 9:20 AM, Anthony Jones <mailto:ajo...@mozilla.com>> wrote: > > We need to have a cheap snapshot mechanism. > > > We don't need that for this. The

Re: Off-main-thread Painting

2013-02-12 Thread Anthony Jones
On 13/02/13 09:52, Robert O'Callahan wrote: > On Wed, Feb 13, 2013 at 9:20 AM, Anthony Jones > wrote: > > We need to have a cheap snapshot mechanism. > > > We don't need that for this. The display list can be constructed on the > main thread and ownership transfer

Re: Off-main-thread Painting

2013-02-12 Thread Clint Talbert
I agree in part with the assertion about testing - that the existing reftests will catch most regressions stemming from this. But I think we also need some measurements around scrolling/responsiveness in order to verify that off main thread painting is giving us the wins we hope it will give

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 9:43 AM, Robert O'Callahan wrote: > A large chunk of the work of off-main-thread painting is refactoring > display lists to be independent of frames, which definitely can and should > be done incrementally and could be done in parallel with the layers &g

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 9:20 AM, Anthony Jones wrote: > We need to have a cheap snapshot mechanism. > We don't need that for this. The display list can be constructed on the main thread and ownership transferred to the painting thread. We always construct the display list from scratch today so t

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 6:17 AM, Jet Villegas wrote: > I assume we would send the same "diff" we use for DLBI over to the > painting thread to minimize the cost. No, the plan is to ship the entire unoptimized display list over to the painting thread and do optimization and DLBI processing there

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
> landing some parts of it incrementally? > I'm concerned about it too, partly because it's shaping up to be a "big bang" landing. However I see no better way forward than getting all available resources behind the current plan and getting it done. A large chunk of the

Re: Off-main-thread Painting

2013-02-12 Thread Anthony Jones
r scheduling? > > --Jet > > > - Original Message - > From: "L. David Baron" > To: "Chris Lord" > Cc: dev-platform@lists.mozilla.org, "Matt Woodrow" , > "Robert O'Callahan" > Sent: Tuesday, February 12, 2013 8:04:38 AM > Sub

Re: Off-main-thread Painting

2013-02-12 Thread Andreas Gal
xt Rendering call agenda. This > should be a lively discussion. > > --Jet > > - Original Message - > From: "Milan Sreckovic" > To: "Matt Woodrow" > Cc: "Robert O'Callahan" , dev-platform@lists.mozilla.org > Sent: Tuesday, February 12

Re: Off-main-thread Painting

2013-02-12 Thread Jet Villegas
ll agenda. This should be a lively discussion. --Jet - Original Message - From: "Milan Sreckovic" To: "Matt Woodrow" Cc: "Robert O'Callahan" , dev-platform@lists.mozilla.org Sent: Tuesday, February 12, 2013 6:50:42 AM Subject: Re: Off-main-thread Pa

Re: Off-main-thread Painting

2013-02-12 Thread Jet Villegas
s Lord" Cc: dev-platform@lists.mozilla.org, "Matt Woodrow" , "Robert O'Callahan" Sent: Tuesday, February 12, 2013 8:04:38 AM Subject: Re: Off-main-thread Painting On Tuesday 2013-02-12 11:17 +, Chris Lord wrote: > Sounds good, I'd like to help if I can. How would

Re: Off-main-thread Painting

2013-02-12 Thread Andreas Gal
On Feb 12, 2013, at 9:50 AM, Milan Sreckovic wrote: > > I think we need a stronger statement than "worthwhile" in this: > > It would be worthwhile to wait for the Layers refactoring to be completed to > avoid too many conflicts. > > when it comes to actually landing code. Something like "we

Re: Off-main-thread Painting

2013-02-12 Thread Milan Sreckovic
I think we need a stronger statement than "worthwhile" in this: It would be worthwhile to wait for the Layers refactoring to be completed to avoid too many conflicts. when it comes to actually landing code. Something like "we should" or even "we must" comes to mind :-) That doesn't preclude

Re: Off-main-thread Painting

2013-02-12 Thread L. David Baron
On Tuesday 2013-02-12 11:17 +, Chris Lord wrote: > Sounds good, I'd like to help if I can. How would this affect the > display-list optimisation process - would we transfer across the > unoptimised display list and re-optimise and process for each > viewport change? I assume with OMTC, we'd sti

Re: Off-main-thread Painting

2013-02-12 Thread Chris Lord
On 12 February 2013 13:05:33, Jean-Marc Desperrier wrote: Matt Woodrow a écrit : to improve both performance and responsiveness of the browser, we are planning on moving painting to happen on a separate thread. I think you should take some time to consider what impact it has on the synchroniza

Re: Off-main-thread Painting

2013-02-12 Thread Jean-Marc Desperrier
Matt Woodrow a écrit : to improve both performance and responsiveness of the browser, we are planning on moving painting to happen on a separate thread. I think you should take some time to consider what impact it has on the synchronization between interactive events and what is visible. - Br

Re: Off-main-thread Painting

2013-02-12 Thread Chris Lord
Sounds good, I'd like to help if I can. How would this affect the display-list optimisation process - would we transfer across the unoptimised display list and re-optimise and process for each viewport change? I assume with OMTC, we'd still async scroll like we do now, but paints would just com

Off-main-thread Painting

2013-02-11 Thread Matt Woodrow
Hi All As an effort to improve both performance and responsiveness of the browser, we are planning on moving painting to happen on a separate thread. My initial draft plan to do this can be found here: https://wiki.mozilla.org/Gecko:OffMainThreadPainting Some of the details still need to be wo