Re: NS_NewURI is now thread-safe

2019-06-10 Thread Cameron McCormack
This is going to let us simplify a whole lot of URL handling code in the style system, where we otherwise have to store strings and lazily creating nsIURIs when we're back on the main thread. Thanks so much! On Mon, Jun 10, 2019, at 1:08 PM, Valentin Gosu wrote: > Hello everyone, > > nsIURI ha

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Bobby Holley
This is awesome work and has been years in the making. Thanks to everyone involved for getting it over the line! On Mon, Jun 10, 2019 at 1:42 PM Valentin Gosu wrote: > On Mon, 10 Jun 2019 at 22:25, Boris Zbarsky wrote: > > > On 6/10/19 4:07 PM, Valentin Gosu wrote: > > > which means nsIURI > >

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Valentin Gosu
On Mon, 10 Jun 2019 at 22:25, Boris Zbarsky wrote: > On 6/10/19 4:07 PM, Valentin Gosu wrote: > > which means nsIURI > > can now be safely used and created on any thread via NS_NewURI. > > That's awesome news! > > > and if you want to add any other special scheme to Gecko you should do > so in NS

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Boris Zbarsky
On 6/10/19 4:07 PM, Valentin Gosu wrote: which means nsIURI can now be safely used and created on any thread via NS_NewURI. That's awesome news! and if you want to add any other special scheme to Gecko you should do so in NS_NewURI in nsNetUtil.cpp Here "special" is in the sense of "Parsed

NS_NewURI is now thread-safe

2019-06-10 Thread Valentin Gosu
Hello everyone, nsIURI has been immutable for a few releases now, meaning once you had one it was safe to use it on any thread (even change it using nsIURIMutator). But until recently you couldn't create a new URI off the main thread (unless you already knew the type of the URI). A few days ago I