Re: NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-23 Thread Patrick McManus
I want to highlight why Its also an important change - there is a very real and important error: your channel content is truncated. Its a bug that necko doesn't tell you about that right now. So we're going to fix that up. The download manager is the obvious victim of this right now. It declares s

Re: NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-22 Thread Boris Zbarsky
On 4/22/14, 10:06 PM, Ehsan Akhgari wrote: That seems like a huge behavior change. :( Yes, it is. There's some at-length discussion in the bug about what behavior various consumers want here. -Boris ___ dev-platform mailing list dev-platform@list

Re: NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-22 Thread Ehsan Akhgari
On 2014-04-22, 9:59 PM, Boris Zbarsky wrote: On 4/22/14, 9:30 PM, Ehsan Akhgari wrote: Do we currently return NS_OK from Necko in such circumstances or another error code? Currently we return NS_OK, so the necko client thinks the transfer completed successfully. That seems like a huge behavi

Re: NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-22 Thread Boris Zbarsky
On 4/22/14, 9:30 PM, Ehsan Akhgari wrote: Do we currently return NS_OK from Necko in such circumstances or another error code? Currently we return NS_OK, so the necko client thinks the transfer completed successfully. -Boris ___ dev-platform maili

Re: NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-22 Thread Ehsan Akhgari
Do we currently return NS_OK from Necko in such circumstances or another error code? On 2014-04-22, 4:21 PM, Daniel Stenberg wrote: Hey all, In the networking team we're about to introduce an error code for "partial transfers" (see https://bugzilla.mozilla.org/show_bug.cgi?id=237623). It will

NS_ERROR_NET_PARTIAL_TRANSFER

2014-04-22 Thread Daniel Stenberg
Hey all, In the networking team we're about to introduce an error code for "partial transfers" (see https://bugzilla.mozilla.org/show_bug.cgi?id=237623). It will be returned when the underlying protocol's framing is cut off and we know that the transfer was indeed partial - not all data arrive