Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-24 Thread Eric Rahm
On Thursday, March 24, 2016 at 10:10:30 AM UTC-7, Justin Dolske wrote: > On 3/24/16 9:54 AM, Ralph Giles wrote: > > On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: > > > >> tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't > >> worry about backward compatibility tho, wh

Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-24 Thread Justin Dolske
On 3/24/16 9:54 AM, Ralph Giles wrote: On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't worry about backward compatibility tho, when MOZ_LOG_* is not set, we fallback to NSPR_LOG_* values. Could this be an opportuni

Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-24 Thread Ralph Giles
On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: > tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't > worry about backward compatibility tho, when MOZ_LOG_* is not set, we > fallback to NSPR_LOG_* values. Could this be an opportunity to shorten NSPR_LOG_MODULES to jus

Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-24 Thread Honza Bambas
On 3/21/2016 18:17, Nicholas Alexander wrote: On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't worry about backward compatibility tho, when MOZ_LOG_* is not set, we fallback to NSPR_LOG_* values. Hi Honza, Thanks f

Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-21 Thread Nicholas Alexander
On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: > tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't > worry about backward compatibility tho, when MOZ_LOG_* is not set, we > fallback to NSPR_LOG_* values. > Hi Honza, Thanks for making the world a better place! I'm s

MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-21 Thread Honza Bambas
tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't worry about backward compatibility tho, when MOZ_LOG_* is not set, we fallback to NSPR_LOG_* values. The longer version: Since the new logging code sits in XPCOM and has no longer anything to do with NSPR and NSPR loggi