Re: Intent to ship: referrerpolicy attribute

2016-01-05 Thread Anne van Kesteren
On Tue, Jan 5, 2016 at 12:26 PM, Masatoshi Kimura wrote: > On 2016/01/04 16:54, Anne van Kesteren wrote: >> There should be, per the specification discussion. E.g., >> >> function isSupported(token) { >> var ele = document.createElement("a") >> ele.referrerPolicy = token >> return el

Re: Intent to ship: referrerpolicy attribute

2016-01-05 Thread Masatoshi Kimura
On 2016/01/04 16:54, Anne van Kesteren wrote: > There should be, per the specification discussion. E.g., > > function isSupported(token) { > var ele = document.createElement("a") > ele.referrerPolicy = token > return ele.referrerPolicy === token > } It didn't work because |ele.ref

Re: Intent to ship: referrerpolicy attribute

2016-01-03 Thread Anne van Kesteren
On Mon, Jan 4, 2016 at 7:46 AM, Franziskus Kiefer wrote: > currently there is no nice way to check which attribute values are > implemented afaik. There should be, per the specification discussion. E.g., function isSupported(token) { var ele = document.createElement("a") ele.referrerPo

Re: Intent to ship: referrerpolicy attribute

2016-01-03 Thread Franziskus Kiefer
currently there is no nice way to check which attribute values are implemented afaik. So far web platform tests haven't been a blocker (so I was told) but if that's something we want to change that's fine with me. On Tue, Dec 29, 2015 at 7:27 PM, Ehsan Akhgari wrote: > On 2015-12-29 10:42 AM, F

Re: Intent to ship: referrerpolicy attribute

2015-12-29 Thread Ehsan Akhgari
On 2015-12-29 10:42 AM, Franziskus Kiefer wrote: we're working on fixing the web-platform tests but those aren't blocker for shipping this. Neither are the additional valid attribute values, which will be added soon in bug 1178337. So if there are no other concerns we will enable the referrerpoli

Re: Intent to ship: referrerpolicy attribute

2015-12-29 Thread Josh Matthews
On 2015-12-29 12:26 PM, Josh Matthews wrote: On 2015-12-29 10:42 AM, Franziskus Kiefer wrote: we're working on fixing the web-platform tests but those aren't blocker for shipping this. Neither are the additional valid attribute values, which will be added soon in bug 1178337. So if there are no

Re: Intent to ship: referrerpolicy attribute

2015-12-29 Thread Josh Matthews
On 2015-12-29 10:42 AM, Franziskus Kiefer wrote: we're working on fixing the web-platform tests but those aren't blocker for shipping this. Neither are the additional valid attribute values, which will be added soon in bug 1178337. So if there are no other concerns we will enable the referrerpoli

Re: Intent to ship: referrerpolicy attribute

2015-12-29 Thread Franziskus Kiefer
we're working on fixing the web-platform tests but those aren't blocker for shipping this. Neither are the additional valid attribute values, which will be added soon in bug 1178337. So if there are no other concerns we will enable the referrerpolicy attribute in 46. On Fri, Dec 4, 2015 at 10:15 A

Re: Intent to ship: referrerpolicy attribute

2015-12-04 Thread Franziskus Kiefer
On Fri, Dec 4, 2015 at 8:57 AM, Jonas Sicking wrote: > I think our implementation still has the problem that specifying > referrerpolicy="none-when-downgrade" on an element has no effect. This > is because the ReferrerPolicy enum uses the same value for RP_Unset, > RP_Default and RP_No_Referrer_W

Re: Intent to ship: referrerpolicy attribute

2015-12-03 Thread Jonas Sicking
I think our implementation still has the problem that specifying referrerpolicy="none-when-downgrade" on an element has no effect. This is because the ReferrerPolicy enum uses the same value for RP_Unset, RP_Default and RP_No_Referrer_When_Downgrade. In general, that enum is a mess :( Would be go

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread Ehsan Akhgari
On 2015-12-02 3:16 PM, Franziskus Kiefer wrote: The web-platform tests are tracked in bug 1168540. But there seems very little work on them recently (in the last 5 month). But we will follow up on this. We have recently been working on fixing up web-platform-tests in order to keep up with spec

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread Franziskus Kiefer
Thanks again Gijs for pointing this out and the quick review. The frontend code is fixed (see bug 1187357). The web-platform tests are tracked in bug 1168540. But there seems very little work on them recently (in the last 5 month). But we will follow up on this. On Wed, Dec 2, 2015 at 3:57 PM, Ja

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread James Graham
On 02/12/15 11:16, Franziskus Kiefer wrote: There are web-platform-tests [1], though they're not up to date with the spec. In particular, they still use |referrer| as attribute name instead of |referrerpolicy|. The idl name is referrerPolicy, is that the capitalisation issue you mean? So there a

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread Gijs Kruitbosch
On 02/12/2015 11:16, Franziskus Kiefer wrote: > they still use |referrer| as attribute name instead of > |referrerpolicy|. I randomly ran into this today while looking at something completely different... Where was the name changed? There is browser frontend code that still uses the old name:

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread Franziskus Kiefer
There are web-platform-tests [1], though they're not up to date with the spec. In particular, they still use |referrer| as attribute name instead of |referrerpolicy|. The idl name is referrerPolicy, is that the capitalisation issue you mean? So there are no tests for interoperability at the moment

Re: Intent to ship: referrerpolicy attribute

2015-12-02 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/2015 10:58 AM, Franziskus Kiefer wrote: > As of Firefox 45 we intend to turn referrerpolicy attribute on by > default on all platforms. It has been developed behind the > network.http.enablePerElementReferrer preference. Other UAs > shipping

Intent to ship: referrerpolicy attribute

2015-12-02 Thread Franziskus Kiefer
As of Firefox 45 we intend to turn referrerpolicy attribute on by default on all platforms. It has been developed behind the network.http.enablePerElementReferrer preference. Other UAs shipping this or intending to ship it are Chrome and Opera [1]. The referrerpolicy attribute as specified in the