Hi dev-platform,
Heads up: I just landed on Inbound a patch that gives nsIntPoint and
nsIntRect the same treatment I gave to nsIntSize: these two classes are now
typedefs of mozilla::gfx::IntPoint and mozilla::gfx::IntRect, which means
that they can't be forward-declared as they used to, but other
On Sun, Mar 29, 2015 at 5:01 PM, Mats Palmgren wrote:
> On 03/27/2015 09:28 PM, Robert O'Callahan wrote:
>>
>> As a followup it's probably worth replacing all of nsIntSize with
>> gfx::IntSize.
>
> I think we should stop using these unit-less types in layout and
> convert the few remaining uses to
On 03/27/2015 09:28 PM, Robert O'Callahan wrote:
As a followup it's probably worth replacing all of nsIntSize with
gfx::IntSize.
I think we should stop using these unit-less types in layout and
convert the few remaining uses to the unit-bearing types in
layout/base/Units.h instead.
I'm taking
Two typedefs for the same thing is just cognitive overhead.
Some judicious typedefs in classes like nsIFrame would be helpful so we
don't have "gfx::" prefixes cluttering up everywhere.
Rob
--
oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo
owoiotoho oao oboroootohoeoro o
On Fri, Mar 27, 2015 at 10:50 PM, Jet Villegas
wrote:
> Probably safe for the integer types, but can we add strong assertions when
> converting from Thebes and Moz2D floats? Bugs like this one are tough to
> debug:
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=1091709
>
> Thanks!
>
>
I haven'
The first part just landed on inbound (Bug 1132854).
On Fri, Mar 27, 2015 at 10:28 PM, Robert O'Callahan
wrote:
> Sounds good. But, is gfx::IntSize going to get a "ToAppUnits" method like
> nsIntSize has?
>
>
The method:
nsIntSize::ToAppUnits(nscoord aAppUnitsPerPixel) const
was replaced by a f
Probably safe for the integer types, but can we add strong assertions when
converting from Thebes and Moz2D floats? Bugs like this one are tough to
debug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1091709
Thanks!
--Jet
On Fri, Mar 27, 2015 at 9:44 AM, Nicolas Silva wrote:
> As many of you
Sounds good. But, is gfx::IntSize going to get a "ToAppUnits" method like
nsIntSize has?
As a followup it's probably worth replacing all of nsIntSize with
gfx::IntSize.
Rob
--
oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo
owoiotoho oao oboroootohoeoro oooro osoiosotoeor
As many of you know, the introduction of Moz2D a while ago added new size,
point and rect classes which are equivalent* to the ones that already
existed in tree (nsIntSize, etc.).
Juggling back and forth between the Moz2D classes and their thebes
equivalent is pretty annoying and until now we have
9 matches
Mail list logo
