Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-08 Thread Ryan VanderMeulen
The fix for bug 1423649 has been merged to m-c. You *should* be good to go now :-) -Ryan On Thu, Dec 7, 2017 at 11:46 PM, Ryan VanderMeulen < rvandermeu...@mozilla.com> wrote: > That's the issue Adam raised, separate from the clang one. It's tracked in > bug 1423649. For now, you can use the wor

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-07 Thread Ryan VanderMeulen
That's the issue Adam raised, separate from the clang one. It's tracked in bug 1423649. For now, you can use the workaround Adam gave in this thread already or you can use the patch attached to the bug. On Dec 7, 2017 11:13 PM, "James Cheng" wrote: > Hi Ryan, > > I did ``./mach bootstrap`` and t

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-07 Thread James Cheng
Hi Ryan, I did ``./mach bootstrap`` and the problem still happened with my VS 15.5 update. I deleted the folders under my .mozbuild and do the bootstrap again but it seems useless... The errors are something like 9:58.83 c:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\gtest/gtest-printers.h(8

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-07 Thread Ryan VanderMeulen
Bug 1423307 has been merged to m-c now. After you've updated m-c, you can re-run |./mach bootstrap| to pick up the newer clang binaries that will fix the _Ty problem. -Ryan On Tue, Dec 5, 2017 at 2:14 PM, Ryan VanderMeulen wrote: > As a follow-up, it looks like updating to a newer LLVM version

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-06 Thread Adam Gashlin
I encountered an issue building with the latest VS update, warnings treated as errors regarding TR1 deprecation, in at least some gtest files. This can be avoided by running as CXXFLAGS=-D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING ./mach build though I imagine there are better ways of adding in t

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-05 Thread Ryan VanderMeulen
As a follow-up, it looks like updating to a newer LLVM version fixes the problem. That update is being tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1423307. For anybody already hitting this bustage locally, you can try updating your clang toolchain under ~/.mozbuild/clang to the one bel

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-05 Thread Ralph Giles
On Tue, Dec 5, 2017 at 9:16 AM, Emilio Cobos Álvarez wrote: > That looks like bindgen, but the error is a C++ one, that is, it's clang > who is choking to parse type_traits. Which version of libclang is this > using? > The libclang version supplied to bindgen is set by https://searchfox.org/moz

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-05 Thread Emilio Cobos Álvarez
On 12/05/2017 05:16 PM, Ryan VanderMeulen wrote: > FYI, the VC++ 2017 v14.12 toolset included in the recently-released VS2017 > 15.5 update appears to have broken building Firefox due to issues with the > Rust compiler (in particular, the version of libclang we ship with it) and > one of the system

Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-05 Thread Ryan VanderMeulen
FYI, the VC++ 2017 v14.12 toolset included in the recently-released VS2017 15.5 update appears to have broken building Firefox due to issues with the Rust compiler (in particular, the version of libclang we ship with it) and one of the system headers: C:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MS