Re: Errors found by cppcheck

2017-06-20 Thread Ehsan Akhgari
On 06/20/2017 12:54 PM, Andrew Halberstadt wrote: Yes, we can blacklist checks with: cppcheck --suppress= You can see the check ids with: cppcheck --errorlist It's actually even more flexible, checks can be disabled for specific files, directories and even lines in the file. And it can all be

Re: Errors found by cppcheck

2017-06-20 Thread Andrew Halberstadt
Yes, we can blacklist checks with: cppcheck --suppress= You can see the check ids with: cppcheck --errorlist It's actually even more flexible, checks can be disabled for specific files, directories and even lines in the file. And it can all be specified in a text file then passed in with: cppchec

Re: Errors found by cppcheck

2017-06-18 Thread Ehsan Akhgari
Is it possible to run cppcheck in a mode where we select which checks it runs? If yes, we could look at the list of true positives that people have found (and continue to find) in bug 1370292 and create an opt-in set of checks that rare valuable ones to have turned on by default, and leave the

Errors found by cppcheck

2017-06-06 Thread Andrew Halberstadt
I was doing a bit of research into cppcheck [1] to see if it might be worth running as a linter (alongside eslint, flake8 etc). More discussion in bug 1370292 [2]. I ran it against the entire tree [3] and got these results: https://bug1370292.bmoattachments.org/attachment.cgi?id=8874498 So far it