Re: DXR gets multi-line highlighting

2014-03-20 Thread Erik Rose
> Note that for this, analysis of the tip of each of -release, -beta, > -aurora and -esr* would be enough. That's significantly more than just > doing -central, but it's also significantly less than doing every single > revision. That is planned! ___ dev

Re: DXR gets multi-line highlighting

2014-03-20 Thread Erik Rose
Great; stories of personal use habits are incredibly helpful. Thanks! Hmm, that gives me an idea: maybe I'll use Mozilla Moderator at some point to collect some use cases We ought to be able to support coloring and highlighting on old revs within DXR. We'll head that direction, freshly reas

Re: DXR gets multi-line highlighting

2014-03-19 Thread Philip Chee
On 19/03/2014 10:20, smaug wrote: > mxr can do specific revision + multiline. > Something like > http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.h?rev=492ce94e6528&mark=94,96,98,100-113,120-134#90 > > You get the revision number from the bottom of the page. (That UI isn't t

Re: DXR gets multi-line highlighting

2014-03-19 Thread Mike Hommey
On Thu, Mar 20, 2014 at 10:26:31AM +1300, Karl Tomlinson wrote: > Erik Rose writes: > > > Once we have request-time rendering of indexed content, it will > > be a lot more straightforward to fetch and render arbitrary revs > > out of version control the same way. We just won't have > > analysis—on

Re: DXR gets multi-line highlighting

2014-03-19 Thread Karl Tomlinson
Erik Rose writes: > Once we have request-time rendering of indexed content, it will > be a lot more straightforward to fetch and render arbitrary revs > out of version control the same way. We just won't have > analysis—only syntax coloring—since we won't have time to build > the whole project dur

Re: DXR gets multi-line highlighting

2014-03-19 Thread Erik Rose
Whee, I get to be a wet blanket! We don't even have any request-writable storage at the moment. SQLite is horrible with write concurrency (and is on an NFS share, to make matters worse), and straight NFS-based writing (sans SQL) would have to be guarded with locks. Even if we solved those probl

Re: DXR gets multi-line highlighting

2014-03-18 Thread smaug
On 03/19/2014 12:10 AM, Karl Tomlinson wrote: On Thu, 13 Mar 2014 12:46:14 -0400, Erik Rose wrote: A lot of you have asked for the ability to select and share ranges within source files. Now, thanks to contributor Jamon Carmisso, you can: http://dxr.mozilla.org/mozilla-central/source/content/m

Re: DXR gets multi-line highlighting

2014-03-18 Thread Jamon Camisso
On 03/18/2014 06:10 PM, Karl Tomlinson wrote: > But for links in bugzilla, please link to a page associated with a > particular revision number, or the line numbers can get very out > of date. Unfortunately I'm not aware of multi-line highlighting > on hg.mozilla.org so this becomes something like

Re: DXR gets multi-line highlighting

2014-03-18 Thread Karl Tomlinson
On Thu, 13 Mar 2014 12:46:14 -0400, Erik Rose wrote: > A lot of you have asked for the ability to select and share ranges within > source files. Now, thanks to contributor Jamon Carmisso, you can: > > http://dxr.mozilla.org/mozilla-central/source/content/media/AbstractMediaDecoder.h#7-13 > > As on

Re: DXR gets multi-line highlighting

2014-03-14 Thread Erik Rose
On Mar 14, 2014, at 9:45 , Mats Palmgren wrote: > Would it possible to also support multiple ranges? You bet. In fact, yours wasn't the only request along those lines. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.o

Re: DXR gets multi-line highlighting

2014-03-14 Thread Jan Keromnes
I discovered this by chance today, shift+clicking the line numbers to reference a code range in a bug. Had no idea it was so recent - thanks a lot! Jan On Thursday, March 13, 2014 5:46:14 PM, Erik Rose wrote: A lot of you have asked for the ability to select and share ranges within source file

DXR gets multi-line highlighting

2014-03-13 Thread Erik Rose
A lot of you have asked for the ability to select and share ranges within source files. Now, thanks to contributor Jamon Carmisso, you can: http://dxr.mozilla.org/mozilla-central/source/content/media/AbstractMediaDecoder.h#7-13 As on GitHub, just click one line number and shift-click another. H