Re: [RFC] Changing the behavior of safe file output stream

2013-10-18 Thread David Rajchenbach-Teller
Sorry, I meant flush() (lower-case), aka PR_Sync. On Fri Oct 18 16:11:43 2013, Neil wrote: > Are we looking at the same stream? Finish() calls Flush() because > otherwise Close() discards the file. > -- David Rajchenbach-Teller, PhD Performance Team, Mozilla signature.asc Description: OpenP

Re: [RFC] Changing the behavior of safe file output stream

2013-10-18 Thread Neil
David Rajchenbach-Teller wrote: At the moment, nsSafeFileOutputStream calls Flush() whenever it is closed. I would like to change that behavior. Are we looking at the same stream? Finish() calls Flush() because otherwise Close() discards the file. -- Warning: May contain traces of nuts. ___

[RFC] Changing the behavior of safe file output stream

2013-10-18 Thread David Rajchenbach-Teller
Cross-posted to dev-platform and dev-extensions, as this may interest add-on developers. At the moment, nsSafeFileOutputStream calls Flush() whenever it is closed. I would like to change that behavior. For reference: - flushing is quite expensive, even when executed off the main thread; - even wi