Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-23 Thread David Rajchenbach-Teller
On 5/23/13 8:45 AM, Tim Taubert wrote: > I talked to Gavin yesterday and we think the best approach would be to > back out the Session Restore changes for now as they don't provide a > real benefit other than code cleanup (and don't block any other work). > > The plan would then be to re-land them

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-23 Thread Ehsan Akhgari
On 2013-05-23 2:45 AM, Tim Taubert wrote: I talked to Gavin yesterday and we think the best approach would be to back out the Session Restore changes for now as they don't provide a real benefit other than code cleanup (and don't block any other work). The plan would then be to re-land them *wit

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-22 Thread Tim Taubert
I talked to Gavin yesterday and we think the best approach would be to back out the Session Restore changes for now as they don't provide a real benefit other than code cleanup (and don't block any other work). The plan would then be to re-land them *with* a kill switch in the same cycle that brin

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-22 Thread David Rajchenbach-Teller
Opening Bug 874817 to add that kill switch. Just for clarification: we might kill add-ons that specifically look at the contents of undocumented private data structures. The advance warning is here because we know that some such add-ons exist. Given that all these refactorings take place on a sin

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-22 Thread Johnathan Nightingale
On May 22, 2013, at 5:33 AM, David Rajchenbach-Teller wrote: > Unfortunately, we do not. > > For the current batch of clean-up changes, it is certainly possible to > add a kill switch. Time-consuming, certainly not nice (the kill switch > will creep in in dozens of places in the code, if not hund

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-22 Thread David Rajchenbach-Teller
Unfortunately, we do not. For the current batch of clean-up changes, it is certainly possible to add a kill switch. Time-consuming, certainly not nice (the kill switch will creep in in dozens of places in the code, if not hundreds), but possible. For the upcoming set of rewrite-half-of-the-code c

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread Ehsan Akhgari
On 2013-05-21 9:07 AM, David Rajchenbach-Teller wrote: As part of project Async, we have been working on refactoring Firefox’ Session Restore to ensure that it does not block the main thread. Part of the work has been cleaning up the code and the data structures involved in Session Restore both t

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread Jorge Villalobos
On 5/21/13 10:01 AM, Lawrence Mandel wrote: > cc Jorge Villalobos. > > - Original Message - >> As part of project Async, we have been working on refactoring >> Firefox’ >> Session Restore to ensure that it does not block the main thread. >> Part >> of the work has been cleaning up the code

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread Lawrence Mandel
cc Jorge Villalobos. - Original Message - > As part of project Async, we have been working on refactoring > Firefox’ > Session Restore to ensure that it does not block the main thread. > Part > of the work has been cleaning up the code and the data structures > involved in Session Restore

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread Kyle Huey
On Tue, May 21, 2013 at 9:07 PM, David Rajchenbach-Teller < dtel...@mozilla.com> wrote: > As part of project Async, we have been working on refactoring Firefox’ > Session Restore to ensure that it does not block the main thread. Part > of the work has been cleaning up the code and the data structu

[Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread David Rajchenbach-Teller
As part of project Async, we have been working on refactoring Firefox’ Session Restore to ensure that it does not block the main thread. Part of the work has been cleaning up the code and the data structures involved in Session Restore both to give us some maneuverability and to improve the chances